learn-co-curriculum / booleans-ruby-readme Goto Github PK

First of all, this problem seems to be limited only to this specific lesson, but I need to test this out further to be sure.

The problem is that whenever I navigate to this specific lesson, somehow the title of the page does not read "Boolean Operators" like it's supposed to. Instead, it takes the title of the lesson that I was previously on. Not only that, but it has the navigation bar (Sandbox/Open IDE, Open in GitHub, and Raise an Issue) from the previous lesson as well.

This is true regardless of how I navigate: by hitting "Next Lesson" from "Booleans and Truthiness in Ruby" (the lesson preceding the Boolean Operators lesson), by hitting the "back" button to go from my current lesson back into "Boolean Operators", and even by using the Curriculum navigation bar to go to "Boolean Operators" when I'm in another lesson.

I tried fixing this by navigating to the "Boolean Operators" lesson when I'm in that lesson, but it will not work. The reason for this is that the navigation bar is ALSO showing that I am still in the other lesson. The only way that I can currently fix this is by hitting "Refresh".

Here's an example of what I'm talking about:

Notice above that the lesson content, tab title, and web address are all correct, but the title on the page itself (HTML Basics) is incorrect. And as shown below, the Curriculum navigation menu also shows that I am currently in "HTML Basics" rather than "Boolean Operators":

I realize that this isn't the biggest bug out there, but it may not be limited to this lesson only. Thanks for checking this out!

Sdcrouse

There are 2 or 3 questions on the quiz that don't give an option to answer them. Since I can't enter any input, I can't complete the quiz or the lesson.

we need to briefly explain what we mean by boolean (again), how operators work to return true/false in beginning.

In the boolean operators section of this module, we suggest they:

Drop into IRB and use !! (the "double-bang operator") to determine that the string "hi" is truthy:

Would it be better to suggest they "drop into pry" instead of IRB, since we already had students download and use it in the debugging with pry module?

My quiz will not mark as complete.

I think a couple of the questions are buggy because they did not have any "true" or "false" options.

Under Operator Operations it says >= represents greater than or equal to. I believe its supposed to say >= instead.

We had:

???

# Logical Operators Quiz

?: `true && true`

(X)`true` ( )`false`

?: `false && true`

( )`true` (X)`false`

?: `1 == 1 && 2 == 1`

( )`true` (X)`false`

?: `"test" == "test"`

(X)`true` ( )`false`

?: `1 == 1 || 2 != 1`

(X)`true` ( )`false`

?: `true && 1 == 1`

(X)`true` ( )`false`

?: `false && 0 != 0`

( )`true` (X)`false`

?: `true || 1 == 1`

(X)`true` ( )`false`

?: `"test" == "testing"`

( )`true` (X)`false`

?: `1 != 0 && 2 == 1`

( )`true` (X)`false`

?: `"test" != "testing"`

(X)`true` ( )`false`

?: `"test" == 1`

( )`true` (X)`false`

?: `!(true && false)`

(X)`true` ( )`false`

?: `!(1 == 1 && 0 != 1)`

( )`true` (X)`false`

?: `!(10 == 1 || 1000 == 1000)`

( )`true` (X)`false`

?: `!(1 != 10 || 3 == 4)`

( )`true` (X)`false`

?: `!("testing" == "testing" && "Zed" == "Cool Guy")`

(X)`true` ( )`false`

?: `1 == 1 && (!("testing" == 1 || 1 == 0))`

(X)`true` ( )`false`

?: `"chunky" == "bacon" && (!(3 == 4 || 3 == 3))`

( )`true` (X)`false`

?: `3 == 3 && (!("testing" == "testing" || "Ruby" == "Fun"))`

( )`true` (X)`false`


???

I removed it because it's from Zed's work. I updated the examples - we could use those - but let's just make a new quiz.

@SophieDeBenedetto @AnnJohn

The use of istrue and isfalse as questions and answers for the quiz can be confusing. Since they are not defined variables, if read literally, the question seems to ask for the return value of the boolean operator with two undefined values.

Example of a question and two answer choices:

isfalse && istrue
istrue
is false

To avoid confusion, a short note at the beginning of the quiz would help. For example, immediately after "Let's Practice!":
Note: for the quiz, istrue represents the boolean true or any statement that evaluates to true (a truthy statement), and isfalse represents the boolean false or any statement that evaluates to false (a falsey statement).

I think the quiz ought to be at the end of the lesson because the lesson currently has the quiz before the "More Comparison Operators" section. The problem with this is that the quiz uses !=, which is not introduced until the "More Comparison Operators" section.

Another alternative to switching the quiz and the "More Comparison Operators" section around would simply be to introduce != in the section before the quiz.

I realize that this is minor, but it could potentially avoid confusion from students who have not encountered != before. Thanks for looking into this!

Sdcrouse

remove tags table, add to .learn file, add objectives

maybe add quiz after?

I attempted to fix the problem by adding some missing back ticks, but it still isn't working for me.

The page says to type !!"hi" to see a true response, but irb warns when this happens; might want to give users a heads-up and explain why it returns such an error.

2.2.2 :004 > !!"hi"
(irb):4: warning: string literal in condition
=> true
2.2.2 :005 >

Weird to mark all the correct answers for each of these practice examples, isn't it?

There are merged branches on this repo which look like they can be deleted.

@SophieDeBenedetto

?: !(istrue && isfalse)
evaluates to true

?: !(1000 == 1 || 10000 == 10000)
evaluates to false

?: 30 == 30 && (!("boolean" == "booleans" || "Coding" == "Awesome"))
evaluates to true

number and conditions has the wrong answer on problem # 15
it should be true.