leankit / leankit.integrationservice Goto Github PK

The GitHub Target is hard coded to go to api.github.com (the github.com website), not a local GitHub Enterprise server (similar to an on-prem TFS).

The api is the same between the two, so it looks like it would be as easy to allowing a configuration as to either GitHub.com or GitHub Enterprise.

I'd submit a pull request if I had a better feel for how you expose the configuration options, but it seems pretty simple.

Only gotcha worth noting is that the api endpoint is slightly different:
GitHub.com: api.github.com
GitHub Enterprise: {hostname_for_github_enterprise}/api/v3/

in IntegrationService.Targets.JIRA.Jira

jqlQuery = string.Format(project.Query, queryAsOfDate.ToString("yyyy/MM/dd hh:mm"));

results in a formated DateTime String like "yyyy.MM.dd hh:mm" if executed on a german System (which results in an exception in Jira

Date value '1.2.2015 12:55' for field 'updated' is invalid. Valid formats include: 'yyyy/MM/dd HH:mm', 'yyyy-MM-dd HH:mm', 'yyyy/MM/dd', 'yyyy-MM-dd', or a period format e.g. '-5d', '4w 2d'.

queryAsOfDate.ToString("yyyy-MM-dd hh:mm") could be used instead, which is not translated into a culter relevant format