Git Product home page Git Product logo

iiif2pdf's People

Contributors

leanderseige avatar lutzhelm avatar

Stargazers

 avatar  avatar

Watchers

 avatar

iiif2pdf's Issues

Unnecessary call of canvas.remove() (which breaks IE compatibility)

The call of canvas.remove() in pdfDoc.prototype.reencodeImg breaks the Internet Explorer compatibility - element.remove() is not supported.

I think that it is not even necessary to call it at this point because the element has not been appended anywhere yet and is only held by a local variable, so it should be taken care of by any browser garbage collection mechanism. The Spec states that remove() doesn't even do anything if the calling element has no parent:
https://dom.spec.whatwg.org/#dom-childnode-remove

If you want to be on the save side, you can still use the following workaround:

if (canvas.parentNode != null) {
  canvas.parentNode.removeChild(canvas);
}

But I'm sure it will never be called.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.