ldaxar / goblocks Goto Github PK

I suggest separating the necessary functions from the unnecessary ones. I.e. the built-ins such as date, cpu and memory should be separated from the rest (maybe put on a separate branch or patch). The RunCmd and Schedule functions should be part of the main package. FunctionMap should not be invoked in the main file either (it is unnecessary to call it when one for example does not want to use the builtin functions). This is all so as to make the program more suckless.

TLDR; The inclusion of the possibility to launch built-in functions is great, but should be made separate so as to better adhere to the suckless philosophy. If the user does not wish to utilise the built-in functions, he need not; if he wants to add more built-in functions, he should be able to.

Edit: it's ttecluk from reddit, we already talked about this.

I was wondering if you have any plans for adding support for signaling clicks to blocks and running a definable command when that happens.
I know this would also involve a patch for dwm, but I think this could be a very neat feature.

Also: I don't mind helping with it, but I also wanted to verify whether this is something you want in Goblocks?

Thanks for the great program.

JSON is not really a config format.

• Quoting is difficult, so are the commas
• Escaping sucks
• No commenting-out system

I propose INI for a config format. Here's how I'd structure the default config

[global]

separator = " | "

[weather]
updateSignal = 39
command = (sleep 5 && curl "wttr.in/London?format=3")
timer = 45m

[datetime]
prefix = 🗓
updateSignal = 35
command = #Date		
format = Monday 02/01/2006 15:04:05		
timer = 1s

[volume]
prefix = 🔊 
updateSignal = 36
command = amixer get Master | awk ' /%/ {print $5 $6}' | head -1 | sed -e 's/][/ /g'
timer = 0
prefix = Mem: 
updateSignal = 37
command = "#Memory"
suffix = %
format = %.2f		
timer = 2s

[cpu]
prefix = CPU: 
updateSignal = 38
command = "#Cpu"
suffix = %
format = %.2f		
timer = 2s

It would be way easier to comment-out, to change and to create new blocks.

As for implementation, https://github.com/go-ini/ini looks quite good.

What do you think?