lcogt / calibration-tom Goto Github PK

The start and end times of a Cal obs request (photometric standard observation) are currently limited to dates, i.e. MM/DD/YYYY. The times default to 0 UT for both start and end. However, submit_calibration in calibration_utils is typically used to schedule a cal observation in a narrow window. For example, an auto_focus must be run before a science observation begins, or a photometric standard must be observed in the last hour of a night.

The cal obs request submission form must allow the window to be specified to a precision of seconds, not days.

• use django.core.cache to manage configdb data
• see lco.py#128 _get_instruments() for example
• see also, tom_base/settings.py CACHES

It'd be nice to see a list of all the Cadences that are unning somewhere

The error message

non_field_errors: According to the constraints of the request, the target is never visible within the time window. Check that the target is in the nighttime sky. Consider modifying the time window or loosening the airmass or lunar separation constraints. If the target is non sidereal, double check that the provided elements are correct.

indicates that the minimum lunar separation angle can be modified in the request form. However, the angle is not among the request parameters. It should be added.

Stacktrace when no Targets are permissible.

e91 FITS file suffix is a guider image. Do not list or download these as data products

for usability.

In the form for submitting a request for photometric standard observation, the value for the IPP must be typed in. However, this value will probably always be 1.0 (i.e. no additional priority factor). A Cal-TOM user will rely on the TC and RR modes to get an urgent calibration scheduled.

The default value, 1.0, should be placed in the IPP field.

self explanatory

On 1/7 or thereabouts, Marshall submitted a repeating flux standard on TLV and CPT for every 3 days.

Expected Behavior

Completed observations should result in a new observation scheduled 3 days later, and failed observations should result in a new observations scheduled 1 day later.

Actual Behavior

Only one observations was scheduled for each site, and one didn't complete. The TLV observation was successfully completed, and the CPT observation resulted in an expired window. Neither one resulted in a cadence.

TLV: https://observe.lco.global/requests/2350318
CPT: https://observe.lco.global/requests/2350317

The seasonal checker is simply looking for if the current month falls between the seasonal_start and seasonal_end months for a target using a basic comparison on line 19 of calibrations.models.target_is_in_season:

seasonal_start <= query_date.month <= seasonal_end

For HR3454, the seasonal_start is 12, and the seasonal_end is 4. Obviously, more logic is needed to account for seasons that span a new year since no month will ever be greater than 12 and also less than 4.

The cal observation request form provides a drop-down list of all targets. Regardless of the target that's selected, the information in the left column (target name, type, RA, DEC, etc) is static. Either the information should change to reflect the target selection, or instructions should be provided for how to change targets.

Some of the instruments ("code") displayed on the Photometric Standards Cadences list have active dynamic cadences for multiple targets. The targets are shown on separate lines. However, the "Latest Observation" links are the same on both lines. Similarly, the "Next Observation" links are the same on both lines. It appears as though, for each instrument, only one cadence is working, although this may just be a problem with the display. Example for kb95.

User "eng" is the PI on 2 proposals (TOM demo scheduler, Cal-TOM scheduler) and a Co-I on 11 proposals (including "standard"). User "nvolgenau" is PI on 28 proposals (including "standard") and Co-I on 13 proposals. When I draft a request to observe a photometric standard, as either user, the Proposal drop-down menu only shows 8 options, and none of them are "standard". Observations of photometric standards should be made for the "standard" proposal.

Lindy noted that "the calibration-tom connects to the observation portal with the eng API key." Why can't user "eng" submit a request for any proposal for which "eng" is a PI or Co-I?

Currently, the Observations tab for each target contains a table listing the facility, when each observation request was created, the status, whether the request has been scheduled, and the number of saved data.

It would be desirable for this table to also list the site at which each observation request is scheduled/was obtained, and/or the name of the cadence request to which the request belongs.

Since the Target dropdown is dynamic it should be refreshed at least when the page reloads.
At present, it doesn't refresh until the TOM is re-deployed.

It's possible to create a target without setting values for "Seasonal start" and "Seasonal end". However, doing so triggers an error when the TOM tries to display various pages.

The "Seasonal" information should not be essential for TOM displays. If the start and end dates are not available when the target is created, then a placeholder should be inserted.

One example. Even if the new target is not an NRES calibrator, the "NRES Cadences" display will instead show an error page with:

• Exception Value: | 'NoneType' object has no attribute 'float_value'
• Exception Location: | /Users/nvolgenau/LCOGT/cal_obs_scheduling/calibration-tom/targeted_calibrations/models.py, line 16, in target_is_in_season

Another example. If I want to edit the target's description, to add the "Seasonal" information, I get an error message with:

• Exception Value: | invalid literal for int() with base 10: ''
• Exception Location: | /Users/nvolgenau/LCOGT/cal_obs_scheduling/calibration-tom/calibrations/templatetags/calibrations_extras.py, line 23, in display_seasonal_start_or_end

So, it's not even possible to fix or delete the problem target. This is preventing me from making changes to my local Cal-TOM.

There's a button labeled "View ConfigDB Instruments" at the bottom of the NRES tab (http://calibration-tom.lco.gtn/nres/nres). Clicking it should display the contents of instrument_type_list.html filled with information about the NRES units. Instead, clicking the button yields an "AttributeError at /nres/instruments". A screenshot of the error summary is attached.

Line 116 of configdb_connections.py is:

instrument_type: str = '',