Collections about premonition HOT 11 CLOSED

Hi @chrisdburr. As I am no longer using Jekyll myself I haven't got more plans for Premonition currently. But I am happy to merge the fix from @bsiever into the codebase and release it. Just need to take time to test it. It can be done within this week. I have to admit that I really forgot about it. Sorry @bsiever.

from premonition.

Demo site has been updated with collection example as well: https://lazee.github.io/premonition-demo/, https://github.com/lazee/premonition-demo

from premonition.

@chrisdburr You're welcome to try my fork: https://github.com/bsiever/premonition . I think I'm only one commit behind and that appears to be updates to the README.

I'm not actively maintaining the fork really. It's where it needs to be for my purposes.

from premonition.

@bsiever Thank you for reporting this. Would it be possible for you to put these changes into a pull request? That would make my life so much easier :)

from premonition.

At lease please send an example that I can use to recreate the problem.

from premonition.

Sorry. I hadn't noticed this request until now. PR created!

from premonition.

Thanks for all your work on this plugin—it's really great!

Just wondering if this is still in active development, and whether there are plans to fix this issue. I've managed to sort a workaround by using the _includes directory and adding some of the default admonitions, but a proper fix would be much smoother.

from premonition.

Thanks, @bsiever. Am I correct in thinking that I just need the contents of the 'lib' directory?

The Jekyll site I'm using this for is hosted on GH, but is built using Netlify for CI/CD purposes. So I'll need to make sure Netlify has access to the updated version of premonition as well.

Thanks for the help in advance. Still getting my head around Jekyll and Ruby.

from premonition.

@chrisdburr I think that's true. I only changed two files (see the file in the pull request: https://github.com/lazee/premonition/pull/39/files), lib/premonition/hook.rb and lib/premonition/processor.rb.

I can't comment much further. I'm not using Netlify or a CI/CD environment, although that's a good idea and I should look into it...). If you don't mind, report on what you find --- if things work/etc., (either here are in my fork).

from premonition.

I will also upgrade dependencies and test Premonition with the latest release of Jekyll for the next release.

from premonition.

4.0.2 has been released and includes the changes from @bsiever . Please test and report if anything is not working as expected.

from premonition.