lawo / nmos-server-api-tests Goto Github PK

The test case "should get subscription notification via websocket when adding a resource" seems wrong to me.

test\query\subscriptions.ts has:

    let testSubscription = {
      'max_update_rate_ms': 100,
      'resource_path': '/nodes',
      'params': {
        'label': 'testsubscription'
      },
      'persist': true
    };

test\resources\node.json has:

  "label": "TestNode1",

If I understand correctly, with these data, the node does not match the subscription parameters, so no notification should be received. If the testSubscription were changed to have 'params': {} or 'params': { 'label': 'TestNode1' }, then the notification should be received.

Thanks.

Tests for subscriptions are missing.