Git Product home page Git Product logo

Comments (2)

laverdet avatar laverdet commented on August 18, 2024

Improved check for invalid calls to run()

If you attempt to run() a fiber that's already running from inside
another fiber you would get a segfault. This is because even though the
fiber isn't running, it hasn't yielded either. Thus where to resume
execution is unclear. This should throw an exception.

Closed by ffa06fe

from node-fibers.

laverdet avatar laverdet commented on August 18, 2024

Hey thanks for the solid report. It seems this is actually a invalid usage of fibers. Since the outer fiber is still running, the run() call can't execute correctly. You'd have to yield() first. You can see this simply with:

Fiber(function() {
  var that = Fiber.current;
  Fiber(function(){
    that.run();
  }).run();
}).run();

It's unclear exactly what that.run() should actually do. So ffa06fe which I just committed will just throw an exception when this happens now.

from node-fibers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.