Comments (4)
We can diff it from npm, looks like some logging changes.. maybe some internal meteor diagnostics that snuck into npm? @renanccastro would be able to comment further.
diff -pubr a/fibers/fibers.js b/fibers/fibers.js
--- a/fibers/fibers.js 2022-08-01 11:47:05.000000000 -0500
+++ b/fibers/fibers.js 2022-08-01 11:46:36.000000000 -0500
@@ -85,21 +85,46 @@ function setupAsyncHacks(Fiber) {
}
}
- function wrapFunction(fn) {
- return function() {
+ function logUsingFibers(fibersMethod) {
+ const logUseFibersLevel = +(process.env.ENABLE_LOG_USE_FIBERS || 0);
+
+ if (!logUseFibersLevel) return;
+
+ if (logUseFibersLevel === 1) {
+ console.warn(`[FIBERS_LOG] Using ${fibersMethod}.`);
+ return;
+ }
+
+ const { LOG_USE_FIBERS_INCLUDE_IN_PATH } = process.env;
+ const stackFromError = new Error(`[FIBERS_LOG] Using ${fibersMethod}.`).stack;
+
+ if (
+ !LOG_USE_FIBERS_INCLUDE_IN_PATH ||
+ stackFromError.includes(LOG_USE_FIBERS_INCLUDE_IN_PATH)
+ ) {
+ console.warn(stackFromError);
+ }
+ }
+
+ function wrapFunction(fn, fibersMethod) {
+ return function () {
+ logUsingFibers(fibersMethod);
var stack = getAndClearStack();
try {
return fn.apply(this, arguments);
} finally {
restoreStack(stack);
}
- }
+ };
}
// Monkey patch methods which may long jump
- Fiber.yield = wrapFunction(Fiber.yield);
- Fiber.prototype.run = wrapFunction(Fiber.prototype.run);
- Fiber.prototype.throwInto = wrapFunction(Fiber.prototype.throwInto);
+ Fiber.yield = wrapFunction(Fiber.yield, "Fiber.yield");
+ Fiber.prototype.run = wrapFunction(Fiber.prototype.run, "Fiber.run");
+ Fiber.prototype.throwInto = wrapFunction(
+ Fiber.prototype.throwInto,
+ "Fiber.throwInto"
+ );
} catch (err) {
return;
diff -pubr a/fibers/package.json b/fibers/package.json
--- a/fibers/package.json 2022-08-01 11:47:05.000000000 -0500
+++ b/fibers/package.json 2022-08-01 11:46:36.000000000 -0500
@@ -1,6 +1,6 @@
{
"name": "fibers",
- "version": "5.0.1",
+ "version": "5.0.2",
"description": "Cooperative multi-tasking for Javascript",
"keywords": [
"fiber",
from node-fibers.
Hi @laverdet, we created a tag in our fork, but Renan informed us we should use this one. I've made this PR to update this repository, so we create the tag 5.0.2.
Could you give me admin access as well?
from node-fibers.
Hi, @laverdet I'm not member of Meteor core anymore, sorry. I've pinged them and Denilson or Fred will chime in pretty soon.
from node-fibers.
As I created the new v5.0.2 tag, I'm closing this issue now https://github.com/laverdet/node-fibers/releases/tag/v5.0.2.
from node-fibers.
Related Issues (20)
- Release precompiled versions for Node v15 HOT 1
- Binary is not included when installing fibers on Ubuntu 18.04 with Node 15 HOT 1
- ES6 Module support
- NPM install error for fibers HOT 1
- npm install fibers with error(node v12.15.0) HOT 8
- A Big Thank You HOT 3
- Debian9: Assertion `thread_id_key != 0x7777' failed HOT 2
- C++ compile errors trying to install fibers @3.1.1 HOT 4
- node process blocks if you use fiber in proces.once('exit', ...) callback
- not support python3?
- what to do it does not work on node 16 but I really need this package for the code to work HOT 1
- New NPM version released HOT 1
- latest version 5.0.2 won't install HOT 2
- Maintenance
- Whether the node version v16.x.x is supported HOT 1
- Fails to build on debian testing (required for rocket.chat 😕 ) HOT 4
- node: ../src/coroutine.cc:134: void* find_thread_id_key(void*): Assertion `thread_id_key != 0x7777' failed. Aborted (core dumped)
- When i start my back-end app then saw this error recently
- Node 20.6.1 support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-fibers.