Git Product home page Git Product logo

Comments (4)

laverdet avatar laverdet commented on July 18, 2024 2

We can diff it from npm, looks like some logging changes.. maybe some internal meteor diagnostics that snuck into npm? @renanccastro would be able to comment further.

diff -pubr a/fibers/fibers.js b/fibers/fibers.js
--- a/fibers/fibers.js	2022-08-01 11:47:05.000000000 -0500
+++ b/fibers/fibers.js	2022-08-01 11:46:36.000000000 -0500
@@ -85,21 +85,46 @@ function setupAsyncHacks(Fiber) {
 			}
 		}
 
-		function wrapFunction(fn) {
-			return function() {
+		function logUsingFibers(fibersMethod) {
+			const logUseFibersLevel = +(process.env.ENABLE_LOG_USE_FIBERS || 0);
+
+			if (!logUseFibersLevel) return;
+
+			if (logUseFibersLevel === 1) {
+				console.warn(`[FIBERS_LOG] Using ${fibersMethod}.`);
+				return;
+			}
+
+			const { LOG_USE_FIBERS_INCLUDE_IN_PATH } = process.env;
+			const stackFromError = new Error(`[FIBERS_LOG] Using ${fibersMethod}.`).stack;
+
+			if (
+				!LOG_USE_FIBERS_INCLUDE_IN_PATH ||
+				stackFromError.includes(LOG_USE_FIBERS_INCLUDE_IN_PATH)
+			) {
+				console.warn(stackFromError);
+			}
+		}
+
+		function wrapFunction(fn, fibersMethod) {
+			return function () {
+				logUsingFibers(fibersMethod);
 				var stack = getAndClearStack();
 				try {
 					return fn.apply(this, arguments);
 				} finally {
 					restoreStack(stack);
 				}
-			}
+			};
 		}
 
 		// Monkey patch methods which may long jump
-		Fiber.yield = wrapFunction(Fiber.yield);
-		Fiber.prototype.run = wrapFunction(Fiber.prototype.run);
-		Fiber.prototype.throwInto = wrapFunction(Fiber.prototype.throwInto);
+		Fiber.yield = wrapFunction(Fiber.yield, "Fiber.yield");
+		Fiber.prototype.run = wrapFunction(Fiber.prototype.run, "Fiber.run");
+		Fiber.prototype.throwInto = wrapFunction(
+			Fiber.prototype.throwInto,
+			"Fiber.throwInto"
+		);
 
 	} catch (err) {
 		return;
diff -pubr a/fibers/package.json b/fibers/package.json
--- a/fibers/package.json	2022-08-01 11:47:05.000000000 -0500
+++ b/fibers/package.json	2022-08-01 11:46:36.000000000 -0500
@@ -1,6 +1,6 @@
 {
 	"name": "fibers",
-	"version": "5.0.1",
+	"version": "5.0.2",
 	"description": "Cooperative multi-tasking for Javascript",
 	"keywords": [
 		"fiber",

from node-fibers.

denihs avatar denihs commented on July 18, 2024 1

Hi @laverdet, we created a tag in our fork, but Renan informed us we should use this one. I've made this PR to update this repository, so we create the tag 5.0.2.

Could you give me admin access as well?

from node-fibers.

renanccastro-provi avatar renanccastro-provi commented on July 18, 2024

Hi, @laverdet I'm not member of Meteor core anymore, sorry. I've pinged them and Denilson or Fred will chime in pretty soon.

from node-fibers.

denihs avatar denihs commented on July 18, 2024

As I created the new v5.0.2 tag, I'm closing this issue now https://github.com/laverdet/node-fibers/releases/tag/v5.0.2.

from node-fibers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.