Build fails against node 0.7.0 about node-fibers HOT 6 CLOSED

Hey aa21a1f fixes the build on node 0.7.x. Fibers doesn't play nice with Isolates at all, so don't try that.. but anything that worked in node 0.6.x should probably work.

from node-fibers.

I'm getting the following error:

make
make -C src fibers.node
make[1]: Entering directory `/home/ubuntu/sourcecode/asyncblock/node_modules/fibers/src'
make[1]: `fibers.node' is up to date.
make[1]: Leaving directory `/home/ubuntu/sourcecode/asyncblock/node_modules/fibers/src'
./test.sh
already-running.js: pass
bad-context.js: pass
child-process.js: pass
current.js: pass
exec.js: pass
exit.js: pass
fibonacci.js: pass
FATAL ERROR: v8::Isolate::Dispose() Disposing the isolate that is entered by a thread.
make: *** [test] Error 1

from node-fibers.

Looks like isolates are getting removed in 0.7.3. We can revisit after it's released.

http://groups.google.com/group/nodejs/browse_thread/thread/ccbceea36f76857d#

Thanks for looking into this!

Chris

from node-fibers.

The build works against v0.7.3!

The benchmarks look good, too. Creating 100,000 asyncblocks (fibers) went from 2.1 seconds in 0.6.9 to 1.5 seconds in 0.7.3.

from node-fibers.

Very cool!

Keep in mind, though, that just invoking new Fiber(function{}) doesn't actually do any work. Coroutines are not created until run() is called for the first time.

from node-fibers.

Yeah, creating an asyncblock runs the contents immediately.

On Feb 13, 2012, at 2:44 PM, Marcel [email protected] wrote:

Very cool!

Keep in mind, though, that just invoking new Fiber(function{}) doesn't actually do any work. Coroutines are not created until run() is called for the first time.

---

Reply to this email directly or view it on GitHub:
#49 (comment)

from node-fibers.