Assertion failed: (delete_me == NULL) about node-fibers HOT 10 CLOSED

Hmm.. I can't think of when that would happen. I would have to toy with it for a bit.. Can you distill this case into something you could send me so I could observe it on my system?

from node-fibers.

No :(
I cannot reproduce it outside of my app business-logic. Think, the bug somewhere in my Sync.async(), but I don't even guess why it may happen.
If you'll explain me a bit more about this assertion, I will try to distill it.

from node-fibers.

This error would get thrown if you have more fibers active than MAX_POOL_SIZE (120) and two of them finish in an abnormal way. If you want to make this easier to test I'd recommend changing "MAX_POOL_SIZE" to 0 in src/coroutine.cc. The assert you're seeing will only get run if more than 120 fibers return in row. By changing it to 0 you can begin testing without needing a lot of circumstance.

from node-fibers.

Ah, great, got it on single request. Digging.

from node-fibers.

Ok, got it:
require('fibers');

var async = function(fn, callback) {
    Fiber(function(){
        callback(null, true)
    }).run();
}

Fiber(function(){
    async(function(err, result){
        console.log(result)
    });
}).run()

-->
Assertion failed: (delete_me == NULL), function fiber_did_finish, file coroutine.cc, line 112.
/Users/octave/bin/node-fibers: line 34: 2939 Abort trap FIBER_SHIM=1 DYLD_INSERT_LIBRARIES="$FIBERS_ROOT/coroutine.dylib" DYLD_FORCE_FLAT_NAMESPACE=1 DYLD_LIBRARY_PATH="$FIBERS_ROOT" $NODE "$@"
but
require('fibers');

var async = function(callback) {
    Fiber(function(){
        var fiber = Fiber.current;
        process.nextTick(function(){
            fiber.run();
        })
        yield();
        callback(null, true);
    }).run();
}

Fiber(function(){
    async(function(err, result){
        console.log(result)
    });
}).run()

-->
true

from node-fibers.

Ah great thanks! It seems that without pooling enabled fibers break down quite easily..

require('fibers');
Fiber(function() {
  Fiber(function() {}).run();
}).run();

I should be able to fix this for you soon.

from node-fibers.

Thanks in advance!

from node-fibers.

Fix failure when multiple fibers finish together

If multiple fibers finished one after in an unexpected way there would
be a memory leak because delete_me would get overwritten. There was an
assertion in place to prevent this scenario, and a case was discovered
which triggers this condition. It was actually quite hard to hit because
the coroutine pool masks this issue very well. The issue was fixed by
deleting dead coroutines as soon as possible, instead of at the next
call to run()

Closed by de187c9

from node-fibers.

Great!
The error was gone. Benchmark succeed.

Thank you!

from node-fibers.

Good to hear :)

from node-fibers.