laurab1 / dice-with-microservices Goto Github PK

While working on the feature of draft stories, I've found that we do not store the rolls of a story, therefore is impossible to edit and check a drafted story.
At this moment (see #20), whenever we roll dices in the rollDice endpoint we save the result in a global variable that is read by the writeStory endpoint. This means that if another roll happens during the process of writing the story, the roll will be overwritten and the checks would fail unexpectedly, and this is not tested. So we need to find another way of dealing with the roll. Some proposal are

1. Send the roll to the client GET and request it back with the POST, this means that the user has control over the dice rolls, but requires minor changes.
2. Save an index of rolls in memory, the fastest solution but memory intensive.
3. Since I'm implementing the editing functionality for drafts, when we roll we create an empty draft with the rolls already in the database and we redirect the user to the edit functionality where he can left the story as a draft or complete the submission.

In my opinion the solution 3 is the best one. No other data structures are needed, no risk of race conditions and the only drawback is that we can have some, minor, number of empty drafts in the database until completion.