Git Product home page Git Product logo

Comments (4)

laughingman7743 avatar laughingman7743 commented on May 25, 2024

This library uses Boto3. It is not necessary to call the close method.
boto/botocore#619 (comment)

The close method doesn't actually do anything.
https://github.com/laughingman7743/PyAthena/blob/master/pyathena/connection.py#L135
https://github.com/laughingman7743/PyAthena/blob/master/pyathena/cursor.py#L40
https://github.com/laughingman7743/PyAthena/blob/master/pyathena/result_set.py#L277

from pyathena.

rinatio avatar rinatio commented on May 25, 2024

Thank you! Does the same apply to the cursor? Also does it make sense to reuse the connection itself or it's caching a session internally when we call connect?

from pyathena.

laughingman7743 avatar laughingman7743 commented on May 25, 2024

This also applies to the cursor. Whether to cache the session is likely to depend on the urllib3 implementation.
I'm not familiar with it, but it seems that you can set the value of max_pool_connection.
boto/botocore#619 (comment)

The keyword argument specified in config is passed to the Boto3 client.
https://github.com/laughingman7743/PyAthena/blob/master/pyathena/connection.py#L67

from pyathena.

rinatio avatar rinatio commented on May 25, 2024

Great, makes sense. It is very helpful, thank you.

from pyathena.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.