Git Product home page Git Product logo

Comments (5)

laughingman7743 avatar laughingman7743 commented on July 24, 2024 1

I have confirmed that the error occurs in SQLAlchemy 1.x. I will fix it.

from pyathena.

Tobotimus avatar Tobotimus commented on July 24, 2024 1

Awesome, thanks @laughingman7743!

FWIW I found this commit sqlalchemy/sqlalchemy@91501e0 which alludes to the cause of this issue:

Additionally, to support annotations for methods that
make use of @decorator, @Generative etc., modified
format_argspec_plus to no longer return "args", instead
returns "grouped_args" which is always grouped and
allows return annotations to format correctly.

This seems to be relevant since AthenaDialect.get_view_definition() is decorated with @sqlalchemy.engine.reflection.cache.

from pyathena.

laughingman7743 avatar laughingman7743 commented on July 24, 2024

Strange, all tests pass.
https://github.com/laughingman7743/PyAthena/actions/runs/6242621017
What version of SQLAlchemy are you using?

from pyathena.

laughingman7743 avatar laughingman7743 commented on July 24, 2024

https://github.com/laughingman7743/PyAthena/blob/v3.0.7/pyathena/sqlalchemy/base.py#L1108
It seems that an error is occurring with this type hint, so it may be possible to remove this type hint. I don't think the type hint is required.

from pyathena.

Tobotimus avatar Tobotimus commented on July 24, 2024

I'm having this issue with SQLAlchemy 1.4.49.

from pyathena.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.