Git Product home page Git Product logo

Comments (5)

laughingman7743 avatar laughingman7743 commented on May 24, 2024

I don't usually use Pandas. I don't know what solution is best.

[1] Either we follow pandas and convert to object the column involved in the issue (I'm not sure we can detect the faulty column, so we could convert all columns with dtypes that are not Na compatible.)

[2] Convert booleans (I understand from the PR above that int is already na safe ) to int and warn the user.

Which method do you think is better?

from pyathena.

laughingman7743 avatar laughingman7743 commented on May 24, 2024

Related: #100

from pyathena.

tanguycdls avatar tanguycdls commented on May 24, 2024

Hi, thanks for the prompt answer ! I did a PR that respects Pandas Type Promotion so bool will be casted to object dtypes and let the user decide what they want to do with it.

from pyathena.

laughingman7743 avatar laughingman7743 commented on May 24, 2024

Thank you for your PR. I understood what kind of implementation should be done.
I'm thinking of refactoring the Converter class to use it with PandasCursor.
https://github.com/laughingman7743/PyAthena/blob/master/pyathena/converter.py
I plan to try it on a weekend.

from pyathena.

laughingman7743 avatar laughingman7743 commented on May 24, 2024

I implemented it so that dtype and converter can be customized freely in the following branches.
Please make sure. 🙏
#104

from pyathena.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.