Comments (5)
I don't usually use Pandas. I don't know what solution is best.
[1] Either we follow pandas and convert to object the column involved in the issue (I'm not sure we can detect the faulty column, so we could convert all columns with dtypes that are not Na compatible.)
[2] Convert booleans (I understand from the PR above that int is already na safe ) to int and warn the user.
Which method do you think is better?
from pyathena.
Related: #100
from pyathena.
Hi, thanks for the prompt answer ! I did a PR that respects Pandas Type Promotion so bool will be casted to object dtypes and let the user decide what they want to do with it.
from pyathena.
Thank you for your PR. I understood what kind of implementation should be done.
I'm thinking of refactoring the Converter class to use it with PandasCursor.
https://github.com/laughingman7743/PyAthena/blob/master/pyathena/converter.py
I plan to try it on a weekend.
from pyathena.
I implemented it so that dtype and converter can be customized freely in the following branches.
Please make sure. 🙏
#104
from pyathena.
Related Issues (20)
- Sqlalchemy Create ICEBERG table wrong Partition clause HOT 3
- Python 3.10: No module named 'distutils.util' HOT 8
- PandasCursor interfering with pandas.DataFrame writing to s3 HOT 8
- Cannot specify Athena workgroup when using sqlalchemy HOT 2
- Add LIMIT as argument for execute HOT 3
- Support `json_serializer` and `json_deserializer` engine/dialect paremeters HOT 1
- SyntaxError when importing AthenaDialect HOT 5
- pyathena hijacks pandas s3fs HOT 2
- result_reuse_enable and result_reuse_minutes HOT 2
- Athena Reuse Query Results HOT 2
- Supporting FILTER and other similar operations HOT 2
- Support for Python 3.12
- Implement all fsspec specs in the s3 file system HOT 4
- Mypy Error When using Connection.cursor method to instantiate cursor HOT 2
- Add custom filesystem object to arrow engine HOT 2
- Compatibility issue with SQLAlchemy<1.4 HOT 2
- `UUID` in a query gets garbled HOT 3
- Add support for Spark calculations HOT 8
- Add Endpoint_URL param to SQLAlchemy HOT 2
- SQLAlchemy dialect uses deprecated dbapi() method HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyathena.