allow local configuration for cdn assets about asciidoctor-treeview HOT 12 CLOSED

Can you tell me more about your use case?
Are you using plain asciidoctorjs or antora?

Would it be enough to provide a way to override the path so that you can define where to look for the icons?

Something like this:

const default path =  `https://cdn.jsdelivr.net/npm/[email protected]/icons`
const url = (getPathFromConfiguration() || default_path) + `/${icon}`

Is that enough? I also was thinking about retrieving all used icons into a local folder and then to point to the local folder in a relative way.

from asciidoctor-treeview.

I'm using Antora.

Yes -- if I could configure a path, that would be great. Ideally, it would be something that could be set in any runtime, but my priority is Antora.

from asciidoctor-treeview.

I wonder if it's possible to also add these icons to the Antora UI Bundle? I'd be willing to throw these in there, but I'd still need a way to specify an alternate path.

from asciidoctor-treeview.

About Antora I was thinking about directly adding the icons into the UI catalog so that the build process is putting then into the right folders.
Putting them into UI bundle might not be effective because then you need to know upfront which icons you want to use and adding all icons would make the ui-bundle quite big. Doing this during the Antora build has the benefit that only the files will be copied that are used in the pages.

I will take a look into this how easy this could be implemented or if there could be also an intermediate solution. A dynamic and a configurable static approach.

from asciidoctor-treeview.

That would be terrific, thank you!

from asciidoctor-treeview.

So I implemented multiple improvements:

• Antora copies now all used icons to img/treeview as default from the material-icons-theme module

• Asciidoctor uses jsdelivr as default url

• Additionally it is possible to

  • embed icons in css as data-uri (antora: icon_source: embedded | Asciidoctor: :treeview-icon-source: embedded)
  • custom url in Asciidoctor :treeview-icon-source:

  Please read the documentation for further information and try it out. Feedback is appreciated.

from asciidoctor-treeview.

@DryHumorInDC is this working for you?

from asciidoctor-treeview.

So sorry, I just saw this. Unfortunately, I am not only without Internet connectivity at runtime, but also at build-time. Therefore, I shall try moving the assets and utilizing the :treeview-icon-source property. I should have time to do this by Friday, and I'll let you know. The approach seems quite doable, so thank you in advance!

from asciidoctor-treeview.

from asciidoctor-treeview.

Ah, gotcha. I just need to wait a few more days on this. My administrators promise to have your npm module pulled in by Friday. Will tag up then. Thanks for your patience. And my have you been busy! I just looked at what you had to do to make this happen; I'm grateful. :-)

from asciidoctor-treeview.

Success!

Thank you so much. I'm very grateful to you. I'm using the antora method, but also tested embedded with equal success.

from asciidoctor-treeview.

That is great. Thx for using it and asking for new features to make it even better.

Have fun with the extension.

from asciidoctor-treeview.