larsth / webduino Goto Github PK

Webduino is an excellent library, but a problem comes when your project 
contains several .cpp (or .pde) files.

Since all the implementation of the WebServer class is written in WebServer.h, 
when you include this header in more than one .cpp (or .pde) file, the GCC 
linker complains of duplicates implementations.

I used this simple solution: I enclosed the whole implementation in a 
#ifndef/#endif, so that the WebServer class implementation is not included if a 
special #define is set (but still included by default).
In my case, I set the #define on each .cpp files and kept the default behavior 
(include implementation) only in the .pde.

I think you should include this hack in the official release.

There's a off-by one error in WebServer::readPOSTparam(). The buffers passed to 
the function will not be fully used.

In the beginning the length of the two buffers is decreased to make sure that 
the trailing 0 is not overwritten:

  // decrement length so we don't write into NUL terminator
  --nameLen;
  --valueLen;

This already ensures that the NULL terminator is not overwritten, so there's no 
need to subtract another character before assigning the read character to the 
buffer:

    // check against 1 so we don't overwrite the final NUL
    if (nameLen > 1)
    {
      *name++ = ch;
      --nameLen;
    }
    else if (valueLen > 1)
    {
      *value++ = ch;
      --valueLen;
    }

It should check against 0 instead of 1.

Example (pseudo-code):

name[2], value[2]
WebServer::readPOSTparam(name, 2, value, 2);

This will decrease both nameLen and valueLen to 1 in the beginning of 
WebServer::readPOSTparam() so that the final check "nameLen > 1" and "valueLen 
> 1" will fail and the read character isn't stored in name/value.


What version of the product are you using? On what operating system?

1.4.1

What steps will reproduce the problem?
1. Use WebDuino Server.pde
2. Open url using firefox 3.5 and post to valid path

What is the expected output? What do you see instead?
Page is posted to, arduino responds as expected


What version of the product are you using? On what operating system?
WebDuino 1.3
Arduino Dem. 328
Fedora 11
Firefox 3.5 or php 5.3+CURL 


Please provide any additional information below.

Using curl directly does not appear to cause this problem, so i wonder if
it caused by http-keep-open type problems.

If you cannot get this working contact me and i shall try and find an
clearer demonstration

Toby

In the function "dispatchCommand()" the verb is processed as follows:

// We now know that the URL contains at least one character.  And,
// if the first character is a slash,  there's more after it.
if (verb[0] == '/')
{
  ...search "m_commands" for a suitable handler
}


BUT... if I supply a prefix of "/" in the webserver's constructor
(which is the default!) then it fails because the leading "/" was
discarded in the function "processConnection()" on this line:

dispatchCommand(requestType, buff + urlPrefixLen


ie. The webserver only works if you supply "" as the prefix
in the constructor. Anything else will cause dispatchCommand()
to fail.

The solution is to remove the check for "/" from dispatchCommand()
(it's completely unnecessary anyway...)

What steps will reproduce the problem?
1. Create a "file upload" form, like the following:

<form action='upload.idf' enctype='multipart/form-data' method='post'>
<p>File Name: <input type='text' name='textline' size='12'></p><p>
Please specify a file: <input type='file' name='datafile' size='40'>
</p><div><input type='submit' value='Send'></div></form>

2. Try to process file contents in some way in your sketch.

What is the expected output? What do you see instead?

Expected: To be able to read through file, and use the "expect" function.

Actual: Application hangs.

What version of the product are you using? On what operating system?

v1.4.1 ATMega328

Please provide any additional information below.

This seems to be because the pushback array, and depth counter, are
declared as chars, while everything else is using int.
http://code.google.com/p/webduino/source/browse/v1.4.1/webduino/WebServer.h#209
http://code.google.com/p/webduino/source/browse/v1.4.1/webduino/WebServer.h#210

Changing these to be int seems to solve the problem, but as far as I can
tell, this will double the amount of RAM used by the pushback array, as
ints are two bytes, while chars are a single byte.

Options:
i) Change to int?
ii) Add #define to allow user to choose which to use?

I think this should be readPOSTparam.

The library doesn't support GET requests that have HTML form parameters like

  GET /myform?d1=1&d2=0

This is because parameter parsing is only done after headers are all
processed and the GET matching code doesn't deal with question mark characters.

I send you a little sample application of webduino with basic authentication.

Hi, I'm misusing this to send you something that might be of interest; I 
combined SDFatlib and modified webduino so I can upload files to the SD card 
and serve files from the SD card. 
I attached the sketch and two files that can be put on the SD card to get a 
file manager that can upload files, delete files, create and delete folders, 
navigate folders, etc.

Reason for sending it to you is that -while this works-, I'm not a particularly 
good C++ programmer and the code might (will!) need some serious reviewing and 
improving before spreading it to a larger audience.

If you're interested in doing so, let me know, if not, I'll just post it in the 
general Arduino forum 

Some of the changes I had to make to the webduino lib:

changed: int m_pushback[100] instead of char.   Otherwise binary files will 
fail to load.  Related variables were also changed. 

added: int WebServer::readNextFormPart(int action)    reads sections of 
multi-part forms.   The action tells it what to look for and what to return.    

changed: void WebServer::processHeaders();  added sections where it reads the 
multipart-form boundary and filenames.

In order to get everything working, you'll have to change the SD_SELECT to the 
correct pin (I believe 4 on the new arduino ethernet shield).
You'll probably also have to set the correct IP Address.

Improvements that are still needed:
- Speed...   Serving files works, but it's pretty slow sometimes.  Also, if a 
browser sends multiple requests, for instance when a css, image or javascript 
file also needs to be served, everything slows down badly.

File uploads are pretty slow as well.   I'm not sure if changing/ adding 
buffers helps.  I'm also not sure where the bottleneck is. My code / webduino / 
ethernet lib / SPI lib / W5100 chip...?

It might be nice to have a send buffer in Webduino, so it doesn't try to send 
each byte at a time when data is written byte-to-byte to the server. I tried 
solving this by adding some buffers myself, but that could be implemented much 
nicer.   Some sort of flush function would have to be added to send all bytes 
that are still in a buffer.  

Regards
Matthijs

As required, I send the missing file webduinoauth.zip in this section.

Claudio.

What steps will reproduce the problem?
1. have a project working with webduino and arduino 0022 (all tested on a 
debian sid system)
2. upgrade to arduino 1.0
3. building fails:

./WebServer.h:203:16: error: conflicting return type specified for ‘virtual 
void WebServer::write(uint8_t)’
/usr/share/arduino/hardware/arduino/cores/arduino/Print.h:48:20: error:   
overriding ‘virtual size_t Print::write(uint8_t)’
./WebServer.h:205:16: error: conflicting return type specified for ‘virtual 
void WebServer::write(const uint8_t*, size_t)’

the signatures in Print.h were changed in arduino to return size_t while they 
returned void in 0022. i tried the "trivial" approach of changing some voids to 
size_t in webduino, but there seems to be a little more to it as i got problems 
with things being purely virtual when they shouldn't.

What steps will reproduce the problem?
1. Use standard demo with /form url for digital output control through radio 
buttons
2. Use a long latency connection, like radiolink in my case
3. reach latencies of pings beyond 3.0 ms or more

What is the expected output? What do you see instead?
It works sometimes until latency rise over a threshold (unclear which one). 
Then the http response never arrives. I tried firebug and Chrome but no erros, 
just stall. It happens to a bunch of them simultaneously (they run on different 
ports on the same LAN, so no hardware specific problem

What version of the product are you using? On what operating system?
Latest github version of webduino library on ArduinoUNO plus Ethernet shield, 
or Arduino Ethernet (both tested). All of them are being used with Ariadne 
bootloader for remote IPreprograming.

Please provide any additional information below.
While the Arduino is in stall mode, any ping or LAN request are server withouth 
problem (you get back full form functionality and digitalbits changes.

Any hint how to at least response with timeout error will be welcome, as this 
arduinos will run on an unatended remote location. Any other experiencing the 
same behaviour, please report your findinds.

Thanks,
Agustin

What steps will reproduce the problem?
1. Send either a PUT or DELETE request to the server
2. Try to figure out what kind of request it was
3. It will be reported as WebServer::INVALID

What is the expected output? What do you see instead?

The request type should be set to either WebServer::PUT or WebServer::DELETE 
instead of WebServer::INVALID


What version of the product are you using? On what operating system?

1.4.1 on Windows


Please provide any additional information below.

This can be easily fixed in WebServer::getRequest(). The result would be the 
the library would allow to build truly RESTful services.

When I try to compile example , such as Web_Demo I get :

In file included from Web_Demo.cpp:24:
/usr/share/arduino/libraries/webduino/WebServer.h:141: erreur: expected ‘,’ 
or ‘...’ before ‘*’ token
/usr/share/arduino/libraries/webduino/WebServer.h:141: erreur: ISO C++ 

... 87 errors later ...

Web_Demo.cpp:98: erreur: ‘htmlHead’ was not declared in this scope

I check my path, and it is good. Any idea ?

A use arduino and ethernetsheilde wiznet based.

I load the webserver demo into the arduino all is going well.

I try to connect to the sever using firefox and http://XX.XX.XX.XX the same
network adress as that changed in the demo script and i get a blank page.

Nothing is comming but there are communication between ethershield and browser.

Whats happend

TY

The WebServer provides the very handy method printP to print a string stored in 
program space.

So, one basically expect that you can write:

  server.printP (PSTR("Hello World !")) ;
  /* the PSTR macro is defined in avr/pgmspace.h */

Unfortunately, you can't because the parameter for printP is of type 
prog_uchar*, whereas the PSTR macro builds a prog_char*.

The fix is very simple, I just replaced all occurrences of prog_uchar by 
prog_char in WebServer.h and now I can use the PSTR macro.