Cannot use finally method of Laravel Batch Job inside an Activity about laravel-workflow HOT 7 CLOSED

@phuclh I have figured out the issue. A fix is coming soon. However you can do this part...

->finally(function () use ($id) {
    $workflow = StoredWorkflow::find($id);
    WorkflowStub::fromStoredWorkflow($workflow)->setReady(true);
})

like this instead...

->finally(function () use ($id) {
    WorkflowStub::load($id)->setReady(true);
})

And it will be simpler for you.

from laravel-workflow.

Nice, thank you for the simpler solution. Have you had a chance to look at the issue when serialization is broken when using Batch with Workflow? Right now, I have to override the serialize, and unserialize methods in DatabaseBatchRepository class to make it works.

protected function serialize($value): string
{
    return Y::serialize($value);
}

protected function unserialize($serialized): mixed
{
    return Y::unserialize($serialized);
}

from laravel-workflow.

@phuclh Yes sir, I figured it out. I have a PR coming to fix it in the next release. 🎉

from laravel-workflow.

Hi
Since batch callbacks are serialized and executed at a later time by the Laravel queue, you should not use the $this variable within the callbacks:
->finally(function () { $this->storedWorkflow->toWorkflow()->setReady(true); })

from laravel-workflow.

Hi Since batch callbacks are serialized and executed at a later time by the Laravel queue, you should not use the $this variable within the callbacks: ->finally(function () { $this->storedWorkflow->toWorkflow()->setReady(true); })

Yes, I already used WorkflowStub::fromStoredWorkflow() to fix that.

However, do you know why the serialization is broken when using Batch with Workflow? Right now, I have to override the serialize, and unserialize method in DatabaseBatchRepository to make it works.

protected function serialize($value): string
{
    return Y::serialize($value);
}

protected function unserialize($serialized): mixed
{
    return Y::unserialize($serialized);
}

from laravel-workflow.

It sounds like you found a workaround. Is this still a blocker for you?

from laravel-workflow.

Great. Thank you so much 👍😊

from laravel-workflow.