languagetool-org / languagetool-browser-addon Goto Github PK

Could be useful if language detection is wrong.

See https://bugs.chromium.org/p/chromium/issues/detail?id=142840

Currently, if the user doesn't want their data to be sent to languagetool.org, they can only click Cancel on first use. We should offer a link to the options dialog so the user can select a different server.

Only suggestions which are included in the error message are shown, so e.g. spelling rules have no suggestions.
related to #4

I checked a text like this: foo <message>, bar - the result said "put a space after the comma", as the <message> was not part of the text anymore, so there was indeed too much whitespace.

Also, the settings dialog contains those not-so-nice language codes only, like "de-DE"

Hi,

Some Text.
This is a example where applying the suggestion does not work. It happens because the context information reported back by the LT server is wrong, because LT does not know about the quoted text which has been ignored.

Could you be so kind to make LanguageTool extension compatible with Firefox’s fork called Palemoon?

When I check this text in the languagetool forum, I get no errors but also no text that tells me that no errors were found:

Daniel Naber is a developer. Here comes more text to improve detection for English.

So the output is that the web service was used and that English US was detected, nothing more. This is probably related to the fact that there are no errors but "Naber" is considered a misspelling originally, but it's in my personal dictionary.

Needs to be interactive, i.e. no configuration dialog. Instead, the user should be able to deactivate the rule of a match (triggering a re-check or filtering of the matches). At the end of the list of errors, the deactivated errors should be listed so they can easily be activated again.

A rule that's turned off can just be filtered from the results, it's not necessary to send the list of deactivated rules to the HTTP API.

I tested as described on https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox, but actually even without disabling the shims, LTFx doesn't work in version 45.0a1, i.e. it won't appear in the context menu nor does the shortcut (Ctrl-Return) cause a check in a textarea.

console.error: languagetoolfx: 
Message: TypeError: window.getSelection is not a function
Stack:
  addSelectionListener@resource://gre/modules/commonjs/sdk/selection.js:345:19

It would be nice to have an option to ignore text below "-- ", the common signature delimiter.

There's almost no settings in Chrome version of LanguageTool, except its API server URL. I suggest to “import” the setting to Chrome version from Firefox version, especially the “Language” and “Native language” options, if it's possible.

The .addword CSS style has a e-resize cursor. I find that a bit confusing. I think the + should itself be a part of the link and have the standard cursor for links.

Useful when the LT widget is not shown in a toolbar.

Bug: CTRL-A and check on languagetool.org and you'll get Javascript code checked. "Text" in between <script>...</script> should probably be ignored.

Hi,

I woulkd like to contribute and update add-on to have LT V2.6.
Also new languages are missing in the add-on.
I would like to contribute for the same.

FYI, I am able to build .xpi from the source code.
But I am unable to include the latest language code "ta-IN".

Suggest me.

Thanks in Advance
--Arun

Checking text in text fields which are in an iframe cannot be checked without selecting the text (e.g. lt forum) - this probably affects all TinyMCE-based editors

Hi.

I think there's a bug with fixing quote by LanguageTool in Chrome (didn't check on Firefox for now). The problem is simple: When I enter classic quotes (opening and closing) from my keyboard, which is "sth" (sth means “some text here” and it's an example for this topic) and checking the typed text in LanguageTool, LT displays a tooltip to replace the typed standard keyboard's quotes to smart quotes, which is “” (in Polish it's „”). However, after I click the opening/closing smart quote, which LT displays I can't replace the standard keyboard's closing/opening quote to smart closing/opening quote with LT, and clicking on smart closing/opening quote doesn't change anything. As far as I can remember, this bug didn't occur in one of the earlier versions (can't remember in which version everything worked fine).

Can you fix this, please? :)

Here's the plan:

• when FF 48 is released, publish WebExtension at addons.mozilla.org and wait for feedback
• when the new extension is tested and FF 48 is released, link it on languagetool.org instead of LanuageToolFx
• adapt description of LanuageToolFx at addons.mozilla.org marking it as deprecated
• have a final update of LanuageToolFx that directs users to the new add-on (code already prepared) - does not work, I get 'Add-ons built with "cfx" are no longer accepted' on http://addons.mozilla.org
• hide LanuageToolFx at addons.mozilla.org so that it cannot be found by search anymore just hiding from search results isn't possible, I've adapted the title instead
• add a tag to git before deleting the old extension's source directory
• delete the translations of LanuageToolFx at transifex
• completely remove LanuageToolFx from addons.mozilla.org

If the text is too long, it gets shortened. However, this may cause the text paramater to end in e.g. %B, which is an invalid and thus illegal sequence. The server then returns Incomplete trailing escape (%) pattern

cfx test fails for me:

Using binary at '/usr/bin/firefox'.
Using profile at '/tmp/tmpmR_HXP.mozrunner'.
Running tests on Firefox 36.0.1/Gecko 36.0.1 ({ec8030f7-c20a-464f-9b0e-13a3a9e97384}) under linux/x86_64.
console.warn: languagetoolfx: Plural form unknown for locale "null"
.JavaScript error: resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpmR_HXP.mozrunner/extensions/[email protected]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/context-menu.js, line 690: TypeError: messageManager is undefined
JavaScript error: resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpmR_HXP.mozrunner/extensions/[email protected]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/context-menu.js, line 690: TypeError: messageManager is undefined
console.log: languagetoolfx: [JavaScript Error: "TypeError: messageManager is undefined" {file: "resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpmR_HXP.mozrunner/extensions/[email protected]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/context-menu.js" line: 690}]
console.log: languagetoolfx: [JavaScript Error: "TypeError: messageManager is undefined" {file: "resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpmR_HXP.mozrunner/extensions/[email protected]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/context-menu.js" line: 690}]
console.error: languagetoolfx: 
  warnings and/or errors were logged.

1 of 2 tests passed.
Total time: 2.608040 seconds
Program terminated unsuccessfully.

I replied to a mail by Marcin and LTfx complained about "Miłkowski", but Firefox's built-in spell checker didn't, because I had added it to my personal dictionary long ago. There might be some problem with special characters?

Let's remind users of the add-on by showing a simple marker in the textarea that the user is using right now. Maybe in the lower right corner, like this:

When clicked, a menu should open with these options:

• "Check text" (this might be tricky, as opening the result popup like when clicking on the icon might not be possible - see FF and Chrome)
• "Disable add-on for this site"

Old idea:
We know from our statistics that many users install the extension, but only a small fraction of them actually uses it. The reason is probably that the extension is rather invisible. There's now code in the extension that can show a reminder toolbar on top of the page. We can show that whenever the user is typing text and hasn't used LT for several days. The code will need to be commented in and the remaining TODOs will need to be fixed.
Or maybe this: http://stackoverflow.com/questions/7730577/how-to-animate-chrome-extension-icon-in-a-callback-function

Using the plugin on Swiss text is confusing, as the language detection will probably return de-DE, thus there will be quite a lot of spelling errors (example: http://de.wikipedia.org/wiki/Z%C3%BCrich). Same for other variants.

Prevent showing the error message that appears for less than a second that says the local server could not be connected ("statuscode: 0"), it's confusing

Dear all,

Thank you so much for your work to provide this Chrome extension!

I was wondering whether it was possible to add an auto-check feature.

This is, for example, provided by Grammarly or Ginger Spellcheck that both automatically check the text while composing.

This is a very intuitive and user-friendly feature.

What do you think?

Thankfully,

~Robert

From an issue languagetool/#115 reported by @X-A-N-A-X:

LanguageTool works fine in Firefox thanks to the following add-on: https://github.com/languagetool-org/languagetool-browser-addon

But this add-on doesn't work with ChatZilla (the IRC client for Firefox): http://chatzilla.hacksrus.com/

I don't know if it's possible but it would be great to have a LanguageTool plugin for ChatZilla, to correct errors before sending a sentence to an IRC channel.

Notice when words are added to persdict.dat so that always the current list of words is used - unfortunately, Firefox writes that file only when the browser exits, so either that would need to change or we would need an API to access the current list.

possibility to undock the panel (overlay webpage or sidebar, https://bugzilla.mozilla.org/show_bug.cgi?id=787395)

It is not possible to check texts on websites which were loaded before the installation of the extension.

I don’t want to have to close a sidebar when there are no mistakes, so just show the popup, which can be closed by clicking anywhere, saying everything is okay.

For example, this complains about the same error twice:

Their is a new way to trigger an error.

Hi,
The addon doesn't use the regional variants, although they appear in the list of languages. For example, using ca-ES-valencia, "seva" should be marked as an error and "seua" should not be marked. Using ca-ES, the reverse is true. I have checked the server side and there is no problem. So it seems the addon is ignoring the variants.

• Check selected text (if any)
• Check text field (if inside text field)

Write a text, trigger checking with Ctrl+Shift+Return and close the popup with Escape. Your focus is now somewhere else, it would be great if it went back to the text field where you triggered the check.

• make the close button of the popup, which is currently just the red character "x" I think, a real image: either the one that's also used when LTFx is shown in the sidebar, otherwise: https://www.openthesaurus.de/static/images/close.png
• change the HTML so that this close button stays visible even when there are several errors and the user scrolls down

if you select a headline and the following paragraph you'll get an error because LT doesn't consider the paragraph (use html instead of text property?)

Password fields (type="password") should probably not be send to the server at all, for privacy reasons and because it doesn't make sense anyway

• Acceptance of the privacy policy doesn't get saved (localStorage.allowRemoteCheck) and user is asked again after browser restart. Tested with FF 49.0a1 (2016-04-29).
• Ctrl+Shift+Space shortcut doesn't work, see https://bugzilla.mozilla.org/show_bug.cgi?id=1246034
• item doesn't show up in context menu (#52) - we need support for openPopup first, see issue at Firefox

Opera is based on the same extensions model as chrome. It would be great if this extension (the chrome version, not the firefox one) is submitted to the opera addons site, so that opera users also have an easy way to use the extension.

You could literally just submit the same .crx file that you have for chrome, as the opera addons store accepts chrome .crx files as well.

(persdict.dat is the user-specific spelling of Firefox)

Wanted to check if there are any plans to trigger a check when focusing or typing in a form field?

The server has recently changed the way it encodes XML and some escaped XML now ends up in the error message, e.g. like this:

Use a smart opening quote here: '“'.