Git Product home page Git Product logo

Comments (5)

eolivelli avatar eolivelli commented on September 26, 2024

Are you on Linux?

@nicoloboschi can you please take a look?

from langstream.

Gagravarr avatar Gagravarr commented on September 26, 2024

Yup, linux, running Ubuntu 22.04.3 LTS (newly setup Azure VM today)

from langstream.

Gagravarr avatar Gagravarr commented on September 26, 2024

In case it helps, the versions of everything I'm running are:

*Docker:* Docker version 24.0.5, build 24.0.5-0ubuntu1~22.04.1
*Minikube:* minikube version: v1.31.2
*Helm:* version.BuildInfo{Version:"v3.13.1", GitCommit:"3547a4b5bf5edb5478ce352e18858d8a552a4110", GitTreeState:"clean", GoVersion:"go1.20.8"}
*KubeCtl:* Client Version: v1.28.3, Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
*Ubuntu:* Ubuntu 22.04.3 LTS
*LangStream:* LangStream CLI 0.4.2
*Mini LangStream:* 0.4.2

Running the wrapped minikube we see no node ports setup for the langstream services, but ingress is enabled in general

KUBECONFIG=.mini-langstream/data/kube-config minikube --profile mini-langstream service list
|---------------|------------------------------------|--------------|---------------------------|
|   NAMESPACE   |                NAME                | TARGET PORT  |            URL            |
|---------------|------------------------------------|--------------|---------------------------|
| default       | kubernetes                         | No node port |                           |
| ingress-nginx | ingress-nginx-controller           | http/80      | http://192.168.49.2:30413 |
|               |                                    | https/443    | http://192.168.49.2:32229 |
| ingress-nginx | ingress-nginx-controller-admission | No node port |                           |
| kube-system   | kube-dns                           | No node port |                           |
| langstream    | langstream-api-gateway             | No node port |                           |
| langstream    | langstream-control-plane           | No node port |                           |
|---------------|------------------------------------|--------------|---------------------------|

from langstream.

Gagravarr avatar Gagravarr commented on September 26, 2024

From my investigations so far, it does seem like helm isn't setting up the external node port that the script is expecting

I'm still not sure if there's an issue with the latest helm script, the minikube env needs extra services adding that full k8s doesn't, there should be a fallback via the ingress (which is setup fine), or something else!

I have at least got a proposed patch that will detect when this has happened and error out, rather than hanging, which is a start...

from langstream.

Gagravarr avatar Gagravarr commented on September 26, 2024

Since the Helm charts are shared between the Mini-Langstream case and more "production" deployments, I'm not sure if it's a good idea to define a target port on the k8s service definition in the helm chart as standard. Doing that would make it harder for people using other approaches (eg ingress or gateway) to override things for their own use

I've seen a few other projects setup their helm charts to support a few different modes for allowing access, which can be toggled between, but that might be an overkill.

I'm tempted to have mini-langstream check to see if external access has already been enabled (as now), and if not send in a short bit of yaml to k8s to setup a NodePort. That way, the helm charts don't have to change, anyone doing their own custom config continues as now, but the mini-langstream case gets a sensible clean setup (without the complexity of a full ingress setup, or the brittleness of kubectl port forwards).

Thoughts?

from langstream.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.