Git Product home page Git Product logo

Comments (5)

weierophinney avatar weierophinney commented on May 30, 2024

@svycka I've checked it and I believe it is desired behaviour. As target we can provide the directory or the file name and in script we can't recognise what you have on mind. So:

  • if provided string is a directory (so must exist) then the file will be moved into that directory,
  • otherwise, path does not exist, so script assumes that it should be a file

Originally posted by @michalbundyra at zendframework/zend-filter#4 (comment)

from laminas-filter.

weierophinney avatar weierophinney commented on May 30, 2024

@webimpress I do not agree with you

if provided string is a directory (so must exist) then the file will be moved into that directory,

sounds ok.

otherwise, path does not exist, so script assumes that it should be a file

this is not documented so I am not sure how you decided this is the desired behavior. Don't understand how having two hidden behaviors from one option is good. maybe new file_prefix or something would be better.


Originally posted by @svycka at zendframework/zend-filter#4 (comment)

from laminas-filter.

weierophinney avatar weierophinney commented on May 30, 2024

@svycka Ok, reopening. Feel free to submit PR - either: documentation update of propose a fix.


Originally posted by @michalbundyra at zendframework/zend-filter#4 (comment)

from laminas-filter.

weierophinney avatar weierophinney commented on May 30, 2024

fixing would mean BC break? if this is the desired behavior


Originally posted by @svycka at zendframework/zend-filter#4 (comment)

from laminas-filter.

weierophinney avatar weierophinney commented on May 30, 2024

@svycka If you propose fix which will be BC Break we will plan it for v3.

I've described what is the current behaviour, and, yes, I can see it can be a bit tricky, but I think it is logical. There is not anything like 'file prefix' right now, the provided target is either directory "where file should be moved" or the new file name. As you are using randomize=true there is randomized string added to the name.


Originally posted by @michalbundyra at zendframework/zend-filter#4 (comment)

from laminas-filter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.