Git Product home page Git Product logo

Comments (6)

Ocramius avatar Ocramius commented on May 30, 2024

The declaration says that it accepts string|array though, not mixed :thinking_face:

laminas-filter/src/StripNewlines.php

Lines 18 to 19 in 29db2dd

* @param string|array $value
* @return string|array

I think we should adjust it to allow mixed, then filter only what is filterable?

From AbstractFilter, I can see that this is completely broken/wrong:

laminas-filter/src/AbstractFilter.php

Lines 84 to 96 in 29db2dd

/**
* Invoke filter as a command
*
* Proxies to {@link filter()}
*
* @param mixed $value
* @throws Exception\ExceptionInterface If filtering $value is impossible.
* @return mixed
*/
public function __invoke($value)
{
return $this->filter($value);
}

from laminas-filter.

internalsystemerror avatar internalsystemerror commented on May 30, 2024

The declaration says that it accepts string|array though, not mixed :thinking_face:

I think we should adjust it to allow mixed, then filter only what is filterable?

This is approach taken in the PR, to expect $value to be mixed.

from laminas-filter.

Ocramius avatar Ocramius commented on May 30, 2024

Linking the PR, since I hadn't seen it before :D

#42

from laminas-filter.

internalsystemerror avatar internalsystemerror commented on May 30, 2024

@Ocramius this is because you are a very busy person and your time is precious. This issue is mentioned in the description of the PR, so they should already be linked but thank you.

from laminas-filter.

Ocramius avatar Ocramius commented on May 30, 2024

Sitting in boring meetings, so it isn't too bad :P

from laminas-filter.

Ocramius avatar Ocramius commented on May 30, 2024

Handled in #42

from laminas-filter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.