Get pod logs when multiple containers are used about kubernetesjoboperator HOT 7 CLOSED

Hi, Thank you for posting!

Would love to help but I would need an example dag, with minimal configuration if you can.

This seems like an error where a pod has multiple containers. Is that correct?

I'm not sure about the timeline, but I'm pretty confident we can resolve this issue.

from kubernetesjoboperator.

Hi, I was able to reproduce your error with (testpod.py),

from airflow import DAG
from airflow_kubernetes_job_operator import KubernetesJobOperator
from airflow.utils.dates import days_ago

default_args = {
    "depends_on_past": False,
    "start_date": days_ago(1),
}

dag = DAG(dag_id="test_multi_container", default_args=default_args, schedule_interval=None)

with dag:
    KubernetesJobOperator(
        task_id="test-multi-container",
        body_filepath="./testdag.yaml",
    )

if __name__ == "__main__":
    dag.schedule_interval = None
    dag.clear()
    dag.run()

Job configuration (testpod.yaml):

apiVersion: v1
kind: Pod
metadata:
  name: 'multi-container-test'
  labels:
    app: 'multi-container-test'
spec:
  restartPolicy: Never
  containers:
    - name: container1
      image: 'alpine:latest'
      command:
        - sh
        - -c
        - |
          echo starting sleep...
          sleep 10
          echo end
      resources:
        limits:
          cpu: 200m
          memory: 500Mi
        requests:
          cpu: 100m
          memory: 200Mi
    - name: container2
      image: 'alpine:latest'
      command:
        - sh
        - -c
        - |
          echo starting sleep...
          sleep 10
          echo end
      resources:
        limits:
          cpu: 200m
          memory: 500Mi
        requests:
          cpu: 100m
          memory: 200Mi

from kubernetesjoboperator.

It may be a few days before I can get to this, apologies for that. The error lies in the Kuberentes api call, where it dose not specify to load the logs from all executing containers inside a pod. This of course can be changed. Error location is here:

Log reader needs to be able to define a container here:

Watcher needs to define a reader for each container here:

This is a nice catch. Thank you.

from kubernetesjoboperator.

Please see resolution PR here:
#39

from kubernetesjoboperator.

Please see resolution version:
https://github.com/LamaAni/KubernetesJobOperator/releases/tag/1.0.19

Please close this issue once validated. Thank you!

from kubernetesjoboperator.

I'm so very grateful for your time. We switch to the new version and it works like a charm. I'm closing the issue.

from kubernetesjoboperator.

Awesome, if you can add a testimonial, that would be fantastic. Here: #40

from kubernetesjoboperator.