BUG: Delete pods after job completion about kubernetesjoboperator HOT 6 CLOSED

I realized that this works out of the box when specifying the finalizers field in metadata:

apiVersion: batch/v1
kind: Job
metadata:
  finalizers:
    - foregroundDeletion

At this point, I wonder:

1. Should this be the default behaviour for this operator? Ex: finalizers are not specified -> default to foreground deletion ?
2. Other option, add some documentation on this topic and call it a day?

from kubernetesjoboperator.

Hi, this should be already happening. Notice in the operator help,

        Added yaml values:

            metadata.finalizers += foregroundDeletion

Location in code,

If this is not happening then it's a bug. Can you please post your Job yaml? This feature is working in my cluster.

from kubernetesjoboperator.

Just tried, on a Kubernetes v1.17.4 cluster:

This works:

apiVersion: batch/v1
kind: Job
metadata:
  finalizers:
    - foregroundDeletion

This doesn't delete pods.

apiVersion: batch/v1
kind: Job
#metadata:
#  finalizers:
#    - foregroundDeletion

from kubernetesjoboperator.

There was a bug there.
Will send a PR soon.

from kubernetesjoboperator.

Please see PR: #29

from kubernetesjoboperator.

Hi, been a while. If you can add a testimonial, that would be fantastic. Here: #40

from kubernetesjoboperator.