lakshmaji / plivo Goto Github PK

Hello,
In document for laravel it is written to add following commands to the app.php:
IN PROVIDERS ARRAY lakshmajim\plivo\PlivoServiceProvider::class,
and
IN ALIASES ARRAY 'Plivo' => lakshmajim\plivo\Facade\Plivo::class,
these commands are not compatible with PSR4 and should be in this way:
IN PROVIDERS ARRAY Lakshmajim\Plivo\PlivoServiceProvider::class,
and
IN ALIASES ARRAY 'Plivo' => Lakshmajim\Plivo\Facade\Plivo::class,

Declaration of Response::toXML() should be compatible with Element::toXML($header = false)

lines 760-768 (vendor/lakshmajim/plivo/src/Plivopackage/plivo.php)

    function __construct() {
        parent::__construct(NULL);
    }

    public function toXML() {
        $xml = Element::toXML($header=TRUE);
        return $xml;
    }

I can fix the error this method:

    public function toXML($header=TRUE) {
        $xml = parent::toXML($header);
        return $xml;
    }

composer require lakshmaji/plivo
Using version dev-master for lakshmaji/plivo
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

Problem 1
- Installation request for lakshmaji/plivo dev-master -> satisfiable by lakshmaji/plivo[dev-master].
- lakshmaji/plivo dev-master requires plivo/plivo-php ^1.1 -> satisfiable by plivo/plivo-php[v1.1.0, v1.1.1, v1.1.2, v1.1.3, v1.1.4, v1.1.5, v1.1.6, v1.1.7] but these conflict with your requirements or minimum-stability.

Installation failed, reverting ./composer.json to its original content.

Thanks for creating the plugin, it's a nice wrapper for the Plivo PHP package. I found a small bug in it. Currently all messages are sent twice because you call the send_message function twice (line 123 to 125 of plivo.php):

$response = $sendsms->send_message($params);
if($sendsms->send_message($params))

If you change the if statement so it takes the response as a result it will work better. The if statement also wasn't working (because you always got an object back it would always say it is sent successfully) so I changed the code to this:

$response = $sendsms->send_message($params);

        if($response["status"] == 202)
        {
            return "success";
        }
        else
        {
            return $response;
        }

I'm trying to install this packpage but it returns the following error

Problem 1
- Conclusion: don't install lakshmajim/plivo 1.2.5
- Conclusion: don't install lakshmajim/plivo 1.2.4
- Conclusion: don't install lakshmajim/plivo 1.2.3
- Conclusion: don't install lakshmajim/plivo 1.2.2
- Conclusion: don't install lakshmajim/plivo 1.2.1
- Conclusion: remove laravel/framework v5.4.25
- Installation request for guzzlehttp/guzzle (locked at 5.3.1) -> satisfiable by guzzlehttp/guzzle[5.3.1].
- Installation request for lakshmajim/plivo ^1.2 -> satisfiable by lakshmajim/plivo[1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5].
- Conclusion: don't install laravel/framework v5.4.25
- lakshmajim/plivo 1.2.0 requires illuminate/support 4.2.* -> satisfiable by illuminate/support[v4.2.1, v4.2.12, v4.2.16, v4.2.17, v4.2.2, v4.2.3, v4.2.4, v4.2.5, v4.2.6, v4.2.7, v4.2.8, v4.2.9].
- don't install illuminate/support v4.2.1|don't install laravel/framework v5.4.25
- don't install illuminate/support v4.2.12|don't install laravel/framework v5.4.25
- don't install illuminate/support v4.2.16|don't install laravel/framework v5.4.25
- don't install illuminate/support v4.2.17|don't install laravel/framework v5.4.25
- don't install illuminate/support v4.2.2|don't install laravel/framework v5.4.25
- don't install illuminate/support v4.2.3|don't install laravel/framework v5.4.25
- don't install illuminate/support v4.2.4|don't install laravel/framework v5.4.25
- don't install illuminate/support v4.2.5|don't install laravel/framework v5.4.25
- don't install illuminate/support v4.2.6|don't install laravel/framework v5.4.25
- don't install illuminate/support v4.2.7|don't install laravel/framework v5.4.25
- don't install illuminate/support v4.2.8|don't install laravel/framework v5.4.25
- don't install illuminate/support v4.2.9|don't install laravel/framework v5.4.25
- Installation request for laravel/framework (locked at v5.4.25, required as 5.4.*) -> satisfiable by laravel/framework[v5.4.25].

Any clue whats may going on?

Thanks :)

Thanks for making a nice package for laravel. Can you update this code for voice?