lakeys / discord-trivia-bot Goto Github PK

This appears to occur when:

• The bot does not have permission to send a message
• The bot does not have the 'embed links' permission and attempts to send an embedded message. (See #25)

Small tweak, but noticeable when manually hosting the bot

This should eliminate most additional cases of users needing to re-type "trivia play"

This occurs when a user has turned off DMs from servers. Can be handled by adding a warning message for the user.

EDIT: This has been implemented with advanced games in v1.6

This will be a temporary solution until games can be saved to the disk and restored without creating a potential restart loop.

EDIT: This can now be done using the "command-whitelist" config option.

As a temporary workaround, users of an active game should at least be notified of the shutdown.

With the increasing number of servers, this is becoming increasingly important for development as it is becoming difficult to reset the bot without interrupting a game.

In some instances, the Discord client receives messages but does not appear to send any. This should be correctable by checking for the message object after calling 'send'.

See issue #39

Implement a proper game system that continues automatically rather than requiring manual commands to start another question

There are currently no error handlers in place for errors when connecting to OpenTDB. The bot should send an error message rather than going offline.

Play a set number of rounds and show users' overall scores at the end

Duplicate; see #35

EDIT: Implemented in v1.4

Should be fixable by checking the 'embed links' permission and, if it is disabled, sending a regular message instead.

Still trying to find a way to consistently replicate this as it only occurs during unintentional outages.

Unable to replicate after several weeks of the bot running consistently.

EDIT: Closing as a few months have passed with no sign of this issue.

Cause unknown, currently investigating.

Have found no information about error online. Only lead is that it appears to happen when the bot joins certain guilds.

EDIT: This also appears to occur when adding reactions to messages (guild text channels only, DMs work fine).

EDIT 2: This issue has been closed as no new occurrences have been recorded over multiple months.

EDIT 3 (Feb 2019): I managed to successfully replicate this by accident. I replicated it by attempting to send messages to a channel that exists, but the bot does not have "read messages" permissions for. I will add an error message explaining this to users that encounter the error.

EDIT: Decided against implementing for the time being.

Use https://opentdb.com/api_count_global.php

Expand applicable configuration options to specific channels, rather than applying them globally.

Currently, configuration is only suitable for users that are hosting the bot for personal use.

EDIT: This has been documented in the Trello, see here for further updates: https://trello.com/c/iCx3FvSC/3-configuration-for-guilds-and-channels

This is to deter users from creating bots that spam trivia or run games 24/7.

This is a measure to prevent unnecessary load on the bot, and, in turn, the Open Trivia Database.

In some instances, this can prevent the bot from logging in at all until restarted.

This may be correctable by restarting the client when there is a client error (rather than logging and ignoring it).

EDIT: Currently unable to replicate.

Note: Ensure that the answer typed is the only content in the message, so strings like 'I think the answer is true?' are not counted.

EDIT: This idea is being scrapped for the time being.

EDIT: This idea has been scrapped for the time being.

This would also improve the response time of the bot by not relying on the OpenTDB request.

One extra question should be kept cached ahead of time so users never need to wait for a request from OpenTDB.

EDIT: Marking as critical due to the bot's growth.

NOTE: For repeating games, always request one question ahead of the current one to avoid waiting for OpenTDB.

(node:11124) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Currently, run.sh auto-restarts the bot while run.bat does not. These files should be functionally identical.

Marked as critical as this negatively affects functionality for Windows systems. Must be fixed before making an initial release.

Stat recording should include total games played, guilds joined, and guilds left. Wherever possible, stats should be recorded on a monthly or weekly bases rather than as a lifetime total. The total weeks/months can be added up to determine an overall total for any given statistic.

A simple .json file should be sufficient to store this kind of data.

Also allow admins to force this and enable/disable voting

EDIT: This has been implemented in a way in the v1.6 update.

EDIT: Implemented in 3ffbeac

The cause of this bug is unknown. May be related to OpenTDB API errors or other connectivity issues.

This is critical as it prevents users in the channel from starting more trivia games.

Unknown cause

The 'prev_participants' value is set around line 108:
'prev_participants': game[id]!==undefined?game[id].participants:null

Example (channel and user IDs redacted):
{ '(redacted)': { inProgress: 1, participants: [], correct_users: [], correct_names: [], correct_times: [], prev_participants: null }, '(redacted)': { inProgress: 1, participants: [ '(redacted)' ], correct_users: [], correct_names: [], correct_times: [], prev_participants: null } }

EDIT: may be related to game messages not sending when users start a game
EDIT2: Confirmed still present in 6c3fae5