lagom / lagom-scala-openshift-smoketests Goto Github PK

Once #1 is merged, this repo should also demonstrate deploying on OpenShift.

This repo requires kustomize so we can adjust the image setting on the Deployment in the YAML files.

OpenShift offers a feature called image-lookup which coul dmake the above obsolete so we could reference image: "hello-lagom:1.0-SNAPSHOT" in all environments instead of requiring:

## in overlays/openshift/kustomization.yml
images:
  - name: "hello-lagom"
    newName: "docker-registry-default.centralpark.lightbend.com/lagom-scala-openshift-smoketests/hello-lagom"

Currently the https://github.com/lagom/lagom-scala-openshift-smoketests/blob/1.5.x/deployment/overlays/openshift/kustomization.yaml#L14 references the images using DockerImage format.

We could try (at least) ImageStreamTag format.

See lagom/lagom-java-openshift-smoketests#12

Once #3 is solved, we should have travis run a deployment and, eventually, some smoke test automatically.

See https://github.com/lightbend/openshift-deployment-guide/issues/19

I'd like to propose dropping the "minimal" and replacing "deployment" with "kubernetes" or "openshift".

"Minimal" is an adjective, like "simple" and "new" and "fast", so I would avoid it.

"Deployment", on the other hand, is too broad. Will this eventually be an example of deploying to AWS? To GCE? If it's just targeting Kubernetes and OpenShift I think it should be called one of the following (and I can see arguments for either, so I'm ambivalent):

• lagom-scala-kubernetes-example or
• lagom-scala-openshift-example