Git Product home page Git Product logo

impersonate's People

Contributors

aelpecyem avatar pyrofab avatar touch-night avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

impersonate's Issues

Potential incompatibility with PlayerPig?

Hi, I run a 1.19 server for myself and my friends, and I was hoping to add this mod to the server. I have also recently added the mod PlayerPig. However, when I tried using the impersonation command, it crashed the server, and then would not let me join subsequently, until I restarted the server without this mod enabled.

I was not sure if it was because of the PlayerPig mod, or because of this mod that the issue was occuring, and wanted to reach out to see if you knew anything about this?

I have also attached the error log. Please let me know if there's anything else I can do to help!

Server crash on startup when used with Luckperms

 java.lang.NullPointerException: Cannot invoke "net.minecraft.class_3218.method_8450()" because the return value of "net.minecraft.server.MinecraftServer.method_30002()" is null
        at Not Enough Crashes deobfuscated stack trace.(1.16.5+build.5) ~[?:?]
        at net.minecraft.server.MinecraftServer.getGameRules(MinecraftServer:1463) ~[intermediary-server.jar:?]
        at net.minecraft.server.MinecraftServer.localvar$znf000$revealImpersonatorsInMessages(MinecraftServer:2725) ~[intermediary-server.jar:?]
        at net.minecraft.server.MinecraftServer.sendSystemMessage(MinecraftServer) ~[intermediary-server.jar:?]
        at net.minecraft.server.command.ServerCommandSource.sendFeedback(ServerCommandSource:215) ~[?:?]
        at me.lucko.luckperms.fabric.FabricSenderFactory.sendMessage(FabricSenderFactory.java:80) ~[LuckPerms-Fabric-5.3.16.jar:?]
        at me.lucko.luckperms.fabric.FabricSenderFactory.sendMessage(FabricSenderFactory.java:44) ~[LuckPerms-Fabric-5.3.16.jar:?]
        at me.lucko.luckperms.common.sender.AbstractSender.sendMessage(AbstractSender.java:85) ~[LuckPerms-Fabric-5.3.16.jar:?]
        at me.lucko.luckperms.common.locale.Message$Args1.send(Message.java:4059) ~[LuckPerms-Fabric-5.3.16.jar:?]
        at me.lucko.luckperms.common.plugin.AbstractLuckPermsPlugin.enable(AbstractLuckPermsPlugin.java:117) ~[LuckPerms-Fabric-5.3.16.jar:?]
        at me.lucko.luckperms.fabric.LPFabricBootstrap.onServerStarting(LPFabricBootstrap.java:146) ~[LuckPerms-Fabric-5.3.16.jar:?]
        at net.fabricmc.fabric.api.event.lifecycle.v1.ServerLifecycleEvents.lambda$static$0(ServerLifecycleEvents.java:37) ~[77dfdc3a-f1c7-477e-a321-79b82f1c8a7a.jar:?]
        at net.minecraft.server.MinecraftServer.handler$znl000$beforeSetupServer(MinecraftServer:3238) ~[intermediary-server.jar:?]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer:645) ~[intermediary-server.jar:?]
        at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer:257) ~[intermediary-server.jar:?]
        at java.lang.Thread.run(Thread.java:831) [?:?]
[18:29:41] [Server thread/ERROR] (Minecraft) This crash report has been saved to: /home/justsnoopy30/Projects/Minecraft Servers/Fabric/SMP/./crash-reports/crash-2021-03-29_18.29.41-server.txt
[18:29:41] [Server thread/INFO] (Beacon) Disabling Beacon v0.7.2...
[18:29:41] [Server thread/INFO] (Beacon) Disabling plugins has not been implemented yet!
[18:29:41] [Server thread/INFO] (Beacon) Disabled Beacon v0.7.2!
[18:29:41] [Server thread/INFO] (luckperms) Starting shutdown process...
[18:29:41] [Server thread/ERROR] (Minecraft) Exception stopping the server
 java.lang.NullPointerException: Cannot invoke "me.lucko.luckperms.common.treeview.PermissionRegistry.close()" because "this.permissionRegistry" is null
        at Not Enough Crashes deobfuscated stack trace.(1.16.5+build.5) ~[?:?]
        at me.lucko.luckperms.common.plugin.AbstractLuckPermsPlugin.disable(AbstractLuckPermsPlugin.java:228) ~[LuckPerms-Fabric-5.3.16.jar:?]
        at me.lucko.luckperms.fabric.LPFabricBootstrap.onServerStopping(LPFabricBootstrap.java:150) ~[LuckPerms-Fabric-5.3.16.jar:?]
        at net.fabricmc.fabric.api.event.lifecycle.v1.ServerLifecycleEvents.lambda$static$4(ServerLifecycleEvents.java:62) ~[77dfdc3a-f1c7-477e-a321-79b82f1c8a7a.jar:?]
        at net.minecraft.server.MinecraftServer.handler$znl000$beforeShutdownServer(MinecraftServer:3248) ~[intermediary-server.jar:?]
        at net.minecraft.server.MinecraftServer.shutdown(MinecraftServer) ~[intermediary-server.jar:?]
        at net.minecraft.server.dedicated.MinecraftDedicatedServer.shutdown(MinecraftDedicatedServer:567) ~[?:?]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer:707) ~[intermediary-server.jar:?]
        at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer:257) ~[intermediary-server.jar:?]
        at java.lang.Thread.run(Thread.java:831) [?:?]```

LuckPerms commands not working

I'm planning to add impersonate to my minecraft server, and added LuckPerms aswell so that I could use the custom Impersonate commands that are in the mod for players that wouldn't be opped. I went to test that it would work but when I tried to add that node to the default group, it wouldn't work and would just say "LuckPerms 5.4.25 installed" or something like that. I looked into the issue and it said I needed some extra plugins for it to work. But those plugins are just that. Plugins. In order for Impersonate to work, I would have to be on fabric, and these extra plugins didn't support a fabric verison. Any ideas on how to get the depenancies for fabric?

Bewitchment/Illuminations compat

At the current moment with the last fix in version 17 of Bewitchment illumination particles now get hidden with the spectral bangle properly allowing players to sneak with their particles. I wonder if there is a way to allow polymorph to hide particles also as these give away a players true identity.

The same bit of code identifying a player as invisible might be able to be applied to the polymorph potion without actually making them go invisible. In a sense the player as we knew them is invisible and they look like another.

I'm not sure if this would be better suited for impersonations compatibility. But figured I would share it here as this is what we found on my server with my modpack. Players that impersonate someone else with polymorph must still go and turn off their particles then restart their game to get illumination particles to disappear and not blow their cover.

^^^ This is a copy of what I posted to Bewitchments issues, the creator informed me that if there was to be a fix for this on Bewitchments end that it would be very hacky in their code. So I am hoping that maybe we are able to get something here with compatibility for impersonations to allow illumination particles to be hidden with the minecraft invisibility tag.

Impersonate problems without Impersonate

Hey my minecraft crashes only in singleplayer. When i install Impersonate it crashes when i never installed Impersonate on the Curseforge Profile it crashes. here is my crashlog https://mclo.gs/C56G0tN
I believe some mod depends on it or something or has it inside the mod idk

Crash on Launch, Possible Compatibility Issue With Modern Industrialization/ARRP

I get a crash on launch. I thought it was ARRP from inside Modern Industrialization. I reported it to them and they seemed to think it was a compatibility issue with the Impersonate mod and that I should report it here. Iโ€™m on Minecraft 1.18, Fabric loader 0.12.8.

This is the crash report I get:
net.fabricmc.loader.impl.FormattedException: java.lang.RuntimeException: Could not execute entrypoint stage 'preLaunch' due to errors, provided by 'advanced_runtime_resource_pack'!
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:159)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:71)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: java.lang.RuntimeException: Could not execute entrypoint stage 'preLaunch' due to errors, provided by 'advanced_runtime_resource_pack'!
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:157)
... 2 more
Caused by: net.fabricmc.loader.api.EntrypointException: Exception while loading entries for entrypoint 'preLaunch' provided by 'advanced_runtime_resource_pack'
at net.fabricmc.loader.impl.entrypoint.EntrypointContainerImpl.getEntrypoint(EntrypointContainerImpl.java:56)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47)
... 4 more
Caused by: java.lang.RuntimeException: Mixin transformation of net.devtech.arrp.ARRP failed
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:234)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:136)
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:155)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:467)
at net.fabricmc.loader.impl.util.DefaultLanguageAdapter.create(DefaultLanguageAdapter.java:50)
at net.fabricmc.loader.impl.entrypoint.EntrypointStorage$NewEntry.getOrCreate(EntrypointStorage.java:117)
at net.fabricmc.loader.impl.entrypoint.EntrypointContainerImpl.getEntrypoint(EntrypointContainerImpl.java:53)
... 5 more
Caused by: org.spongepowered.asm.mixin.throwables.MixinApplyError: Mixin [mixins.impersonate.common.json:MutableTextMixin] from phase [DEFAULT] in config [mixins.impersonate.common.json] from mod [impersonate] FAILED during PREPARE
at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinError(MixinProcessor.java:638)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinPrepareError(MixinProcessor.java:585)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.prepareConfigs(MixinProcessor.java:543)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.select(MixinProcessor.java:462)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.checkSelect(MixinProcessor.java:438)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:290)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:229)
... 13 more
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTargetAlreadyLoadedException: Critical problem: mixins.impersonate.common.json:MutableTextMixin target net.minecraft.class_5250 was loaded too early.
at org.spongepowered.asm.mixin.transformer.MixinInfo.readDeclaredTargets(MixinInfo.java:948)
at org.spongepowered.asm.mixin.transformer.MixinInfo.(MixinInfo.java:882)
at org.spongepowered.asm.mixin.transformer.MixinConfig.prepareMixins(MixinConfig.java:852)
at org.spongepowered.asm.mixin.transformer.MixinConfig.prepare(MixinConfig.java:777)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.prepareConfigs(MixinProcessor.java:540)
... 19 more

Cannot initialize Minecraft on clean Fabric server (injection failure)

This mod will crash the server, even though the installation steps are followed as described.

Steps to reproduce:

  1. Use "Fabric Installer"'s server tab, using loader version 0.11.5 and Minecraft 1.17, download the files, download the server.jar through same installer, generate start scripts.
  2. use the provided start.bat file to initialize first time setup, agree to EULA and run same script again
  3. Wait until server starts up
  4. Put in "impersonate-2.3.0.jar" and "fabric-api-0.35.1+1.17.jar" into the "mods" folder

Terminal output
https://pastebin.com/pwF9HRdu

Gamerule for hiding duplicate player names in player lists.

A friend and I are planning to use impersonate for some multiplayer shenanigans in the near future, but the feature that shows the new player's username in the player list on servers kind of gives away that there's someone disguised as a certain player when the player you're impersonating joins. Showing two of the same player on the player list.

Therefore, I propose some sort of solution: A gamerule that hides the impersonating player from the player list if the true player that is being impersonated by someone else joins and is online. For example:

Someone impersonates the Notch account. And on the tab player list, it shows Notch just normally. But when the real Notch account joins, it won't show two Notches on the player list, just one.

Issue: Fabric Discord Link compatibility

Using Fabric Discord Link with this mod, the discord chat link is able to see both usernames as admins see when the game rule is enabled. Even disabling this option does not fix this issue. This is most likely because the server logs always display both names. Would it be possible to add a config option to enable/disable this.

Server crash unknown cause

[01:09:41] [main/FATAL]: Failed to start the minecraft server
java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'impersonate'!
at net.fabricmc.loader.entrypoint.minecraft.hooks.EntrypointUtils.invoke0(EntrypointUtils.java:53) ~[fabric-server-launch.jar:?]
at net.fabricmc.loader.entrypoint.minecraft.hooks.EntrypointUtils.invoke(EntrypointUtils.java:36) ~[fabric-server-launch.jar:?]
at net.fabricmc.loader.entrypoint.minecraft.hooks.EntrypointServer.start(EntrypointServer.java:32) ~[fabric-server-launch.jar:?]
at net.minecraft.server.Main.main(Main.java:125) [intermediary-server.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_251]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_251]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_251]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_251]
at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:192) [fabric-server-launch.jar:?]
at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:140) [fabric-server-launch.jar:?]
at net.fabricmc.loader.launch.knot.KnotServer.main(KnotServer.java:26) [fabric-server-launch.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_251]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_251]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_251]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_251]
at net.fabricmc.loader.launch.server.FabricServerLauncher.launch(FabricServerLauncher.java:61) [fabric-server-launch.jar:?]
at net.fabricmc.loader.launch.server.FabricServerLauncher.setup(FabricServerLauncher.java:105) [fabric-server-launch.jar:?]
at net.fabricmc.loader.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:49) [fabric-server-launch.jar:?]
Caused by: java.lang.NoClassDefFoundError: net/fabricmc/fabric/api/gamerule/v1/GameRuleFactory
at io.github.ladysnake.impersonate.impl.ImpersonateGamerules.(ImpersonateGamerules.java:27) ~[Impersonate-2.0.1.jar:?]
at io.github.ladysnake.impersonate.Impersonate.onInitialize(Impersonate.java:49) ~[Impersonate-2.0.1.jar:?]
at net.fabricmc.loader.entrypoint.minecraft.hooks.EntrypointUtils.invoke0(EntrypointUtils.java:50) ~[fabric-server-launch.jar:?]
... 17 more
Caused by: java.lang.ClassNotFoundException: net.fabricmc.fabric.api.gamerule.v1.GameRuleFactory
at java.net.URLClassLoader.findClass(Unknown Source) ~[?:1.8.0_251]
at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_251]
at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) ~[?:1.8.0_251]
at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_251]
at net.fabricmc.loader.launch.server.InjectingURLClassLoader.loadClass(InjectingURLClassLoader.java:56) ~[fabric-server-launch.jar:?]
at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_251]
at net.fabricmc.loader.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:161) ~[fabric-server-launch.jar:?]
at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_251]
at io.github.ladysnake.impersonate.impl.ImpersonateGamerules.(ImpersonateGamerules.java:27) ~[Impersonate-2.0.1.jar:?]
at io.github.ladysnake.impersonate.Impersonate.onInitialize(Impersonate.java:49) ~[Impersonate-2.0.1.jar:?]
at net.fabricmc.loader.entrypoint.minecraft.hooks.EntrypointUtils.invoke0(EntrypointUtils.java:50) ~[fabric-server-launch.jar:?]
... 17 more

Fabric Api

I am trying to add this to a 1.17 server can anyone tell me what fabric API it is specifically

Versioning scheme on Modrinth makes it difficult to select correct version in ATLauncher

Minor:

This is by no means a flaw with the versioning scheme, but I did want to make you aware that because it only includes the mod version and no indication of the fabric version within that label, when it gets pulled up on ATlauncher, people are forced to visit the page, look up which modloader versions correspond to the mod version before selecting them.

I don't think this will change anytime soon. I'm not familiar enough with other clients that allow downloading of mods, but I'd be willing to check into it if anyone has a list of them they'd like me to try just to gauge current impact.

Issue logging in after using polymorph potion-Bewitchment

Within a multiplayer server I attempted to polymorph into someone but immediately crashed the server. The other people can log in but when I attempt to do so it crashes and boots everyone out.

This is the error from the console:
[03:47:31] [Netty Epoll Server IO #2/ERROR]: Error receiving packet 52 java.lang.IllegalArgumentException: Don't know how to serialize io.github.ladysnake.impersonate.impl.ImpersonateTextContent@5cba4f2e as a Component

Heres the log
https://pastebin.com/KijbYxFV

Cardboard

When attempting to run a Bewitchment and dependencies alongside cardboard the server will crash and give the following report. I've also taken the ending of the server log before/during the crash. And hopefully having the client latest log can give all the information I can help gather on the subject. I'm also opening up a ticket on their github regarding the same issue at hand.

Log spam

This is from requirem right?

[ForkJoinPool-1-worker-6/WARN]: The mod "impersonate" contains invalid entries in its mod json:

  • Unsupported root entry "credits" at line 12 column 12

[Suggestion] Permissions

Would you be able to add LuckPerms support or config to allow non-opped players to use the command?

popular skins not working.

I am trying to make a cinematic with the dreamSMP members skins. Although when i type
impersonate disguise as GeorgeNotFound
it will not set me as his skin. The same things happens with all of the other members. It seems like it is famous people that it wont allow me to get the skin. In chat it does say

Started impersonating GeorgeNotFound

and my character does its little spin, but it doesnt set me as his skin. im not sure why it does this.

It also will sometimes set my skin to a Dream skin, but not george's. Im not sure why it does that.

but thank you for reading this! it is an awesome mod and it has served me great!

Player data doesn't save when you relog if you impersonate someone

Minecraft Version:
1.16.4

Impersonate Version:
2.0.3

Mods:
Impersonate
Fabric API

What happens:

Starting position and skin
image

Logged out here disguised as friend
image

Relogged aaaand... it put me where I spawned originally because I never logged out when I did the impersonate command
image

this breaks with luckperms

if you impersonate into someone with a luckperms prefix/suffix that in combination with their username is longer than 16 characters (for example if my prefix is 10 characters and my username is 10 characters), it would be longer than 16 characters when you try to impersonate them, causing you to essentially be softbanned until the impersonation is cleared in some way because the game wont let you join with a username longer than 16 characters

this also seems to cause everyone else on the server to disconnect? i wasnt disconnected for some reason (i suspect its because i have /op)

the person with the blue colored prefix is the real person, the one that has the yellow tag is the one impersonating him.

image
image

Cape doesn't render

My friend got the migrator cape but on a server with this mod installed it doesn't render. Removing the mod fixes this issue.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.