Delete .stata_kernel_images folder on kernel shutdown about stata_kernel HOT 4 CLOSED

My 2c

import tempfile
import shutil
import os

# In __init__
self.graphdir = tempfile.mkdtemp()

# In get_graph
gr  = os.path.join(self.graphdir, name + '.svg')
cmd = 'graph export `"{0}"\' , name({1}) as(svg) replace'
self.do(cmd.format(gr, name))

with open(gr) as f:
    img = f.read()

# In do_shutdown
shutil.rmtree(self.graphdir)

So even if the kernel fails for some reason, you won't litter the user's folders with temp folders. It would go into the system temp directory.

from stata_kernel.

Yes I agree, but I was thinking of the dua model, and I'm not sure it would be ok to arbitrarily save images in tmp (likewise with the cross-console history file, not sure that can go in ~ by default. Maybe I could put this setting in the configuration.

from stata_kernel.

The "tmp" folder created via tempfile is only readable and writeable by the user that makes it, AFAIK. I did ask about this when I started work because the DUA model says all the things must be in the user's DUA folder. However, SAS and Stata create temporary files in the system's temporary directory all the time. I was told that was OK.

Nevertheless, an option to specify the images cache directory would certainly be nice.

from stata_kernel.

I'm not sure it's necessary to delete the cache directory anymore, as long as it's always in the same place and now possible to be user defined.

from stata_kernel.