kurtwagner / checkee Goto Github PK
View Code? Open in Web Editor NEWAdd comments to bitbucket pull requests from lint results
License: MIT License
Add comments to bitbucket pull requests from lint results
License: MIT License
Currently it should skip comments on lines you didn't change. However there's been a few comments appearing without line numbers associated regarding unchanged lines. I guess it's building up the comment and instead of skipping it's just not assigning a line to it. At time of submitting the comment it's doing it without a line.
It's common to fail a build when a changed file does not meet the standard but this can make adoption harder and noisy. I propose an option or another command that will exit other than zero if the changed chunks have any errors higher than a given severity (potentially also max number of less severe). e.g,
checkee --fail-on "critical" ...
or maybe
checkee test ...
If there's no source we should exclude it from the error message instead of having a fatal error
If a comment is no longer relevant it will be deleted. This used to cause dangling tasks and comments when such existed on the comment. Now it seems like the comment will just hang around, which gives the impression it's still relevant. I propose we either cross out (e.g, "Message: name is already declared") and/or label resolved comments as "Resolved" when we try to remove a comment that is no longer relevant
If the checkstyle comment contains bitbucket markdown or special characters it's rendered. e.g, in perl you might have
my @something = ("one", "two", "three");
and if @something
is referenced in the message it tags the username "something". Preferably we just want the message part to be escaped or markdown ignored as the other parts controlled by checkee utilises the markdown.
I've tried loading checkee on my Jenkins CLI, but it gives me this error:
/usr/local/share/.config/yarn/global/node_modules/checkee/lib/bitbucket/backend.js:34
}, this._tryAgainInMilliseconds);
^
TypeError: Cannot read property '_tryAgainInMilliseconds' of undefined
at Request.request.(anonymous function) [as _callback] (/usr/local/share/.config/yarn/global/node_modules/checkee/lib/bitbucket/backend.js:34:13)
at Request.self.callback (/usr/local/share/.config/yarn/global/node_modules/request/request.js:186:22)
at emitTwo (events.js:106:13)
at Request.emit (events.js:191:7)
at Request.<anonymous> (/usr/local/share/.config/yarn/global/node_modules/request/request.js:1081:10)
at emitOne (events.js:96:13)
at Request.emit (events.js:188:7)
at IncomingMessage.<anonymous> (/usr/local/share/.config/yarn/global/node_modules/request/request.js:1001:12)
at IncomingMessage.g (events.js:291:16)
at emitNone (events.js:91:20)
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.