kuleuven-ccis / idp-authn-jwt Goto Github PK
View Code? Open in Web Editor NEWShibboleth IdP JWT authentication module
License: Apache License 2.0
Shibboleth IdP JWT authentication module
License: Apache License 2.0
Hi,
It is difficult to correctly track versions of the project, and manage updates because the version is always "1.0-LATEST-SNAPSHOT" in the pom.xml.
Could you increment the version when you publish an update?
Thanks for this really helpful implementation anyways.
I'm using your module to authenticate users in Shibboleth IdP with JWT tokens.
It works all really well, except when there is no cookie at all : the module throws a NullPointerException.
2018-05-16 07:38:44,671 - ERROR [net.shibboleth.idp.authn:-2] - Uncaught runtime exception
java.lang.NullPointerException: null
at java.util.Arrays.stream(Arrays.java:5004)
at be.kuleuven.ccis.shibboleth.idp.authn.impl.InitializeJWTContext.doExecute(InitializeJWTContext.java:65)
at net.shibboleth.idp.authn.AbstractAuthenticationAction.doExecute(AbstractAuthenticationAction.java:98)
at org.opensaml.profile.action.AbstractProfileAction.execute(AbstractProfileAction.java:117)
at net.shibboleth.idp.profile.AbstractProfileAction.doExecute(AbstractProfileAction.java:154)
at net.shibboleth.idp.profile.AbstractProfileAction.execute(AbstractProfileAction.java:126)
at org.springframework.webflow.execution.ActionExecutor.execute(ActionExecutor.java:51)
at org.springframework.webflow.action.EvaluateAction.doExecute(EvaluateAction.java:77)
...
Simply adding a null check seems to fix this issue :
Cookie jwtCookie = null;
if (this.getHttpServletRequest().getCookies() != null) {
jwtCookie = Arrays.stream(this.getHttpServletRequest().getCookies())
.filter(x -> cookieName.equals(x.getName()))
.findAny()
.orElse(null);
}
It's not possible to build the latest version, because of the non available "idp-util" artefact, which was implemented in the latest build.
Hi,
an improvement of your maven script could be to use a custom assembly to generate an archive containing idp-authn-jwt jar and its dependencies, with an assembly.xml file like this :
<id>assembly</id>
<formats>
<format>tar.gz</format>
</formats>
<dependencySets>
<dependencySet>
<outputDirectory>/</outputDirectory>
<useProjectArtifact>true</useProjectArtifact>
<scope>runtime</scope>
<includes>
<include>*:nimbus-jose-jwt:*</include>
<include>*:json-smart:*</include>
<include>*:jcip-annotations:*</include>
<include>*:bcpkix-jdk15on:*</include>
</includes>
</dependencySet>
</dependencySets>
<files>
<file>
<source>${project.build.directory}/${project.artifactId}-${project.version}.jar</source>
</file>
</files>
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.