ksclarke / freelib-utils Goto Github PK

Add another option to avoid resetting a system property that has already been set.

Failing because test paths are hard-coded. Duh. Rewrite the tests.

Would be nice if xmlresourcebundle was embedded in the logger rather than having to write stuff like:

LOGGER.warn(BUNDLE.get("INGEST_FILE_FAIL", jp2));

There is a i18n extension to slf4j but I don't think it is as simple as this would be.

• Fix JarFile utilities so ResourceBundle(s) can be extracted + small refactor

Two ClasspathUtils tests fail when run in mvn site:deploy but run fine with mvn install

See: http://freelibrary.info/freelib-utils/surefire-report.html#info.freelibrary.utilClasspathUtilsTest

The XML resource bundle doesn't work when the modern environment uses named modules. Upgrade to the new ResourceBundleProvider interface to support newer modular environments.

This method doesn't catch child directories if the aDeepConversion boolean is false. It should report files and dirs that are children of the supplied directory, not just files.

Create the corresponding BiConsumers to the Consumers already being used.

Add line numbers to warn, info, and error(?)

• Update PMD
• Refactor to make PMD happy

Add an optional properties file transcoder for the I18nCodesMojo. This will create a properties file from an XML resources file, if configured to do so.

Instead of typing:

mvn info.freelibrary:freelib-utils:generate-codes -DmessageFiles=$(find src -name *_messages.xml)

One could just type:

mvn info.freelibrary:freelib-utils:generate-codes

if the Maven plugin assumed a *_messages.xml file if a specific messageFiles was not supplied.

JDK 8 provides a Base64 implementation now so we can remove that dependency.

To reduce the size of the jar, split out the Maven plugins. They're never needed as dependencies in a project so shouldn't be included in the utils jar.

• Replace old Maven GitHub Action (it's been archived)

StringUtils.formatMessage(String, String[]) is the most obvious, but do throughout.

Provide a way to getenv with a fallback in the same way getProperty works.

Cf. https://github.com/ksclarke/freelib-utils/blob/master/src/main/java/info/freelibrary/maven/MavenLoggingMojo.java

Updating to JDK 17's doclet broke the Javadocs CSS. This has been upstream in freelib-build-tools. Pull the new CSS into this project.

• Fix logging line numbers
• Switch from using simple logger to logback for tests
• Remove obsolete test settings.xml file
• Add question mark constant

PairtreeRoot overrides File and this behavior is not what one would expect from a File.

There are logging messages in these classes that are in the freelib-utils_messages file but not in the messages files of classes that extend them. The result is the message codes come out in the debug messages instead of actual messages. Fix this by removing the debugging logging or have them pull from a different bundle_name than the one that's passed into the extended class.

RIght now this is manually put into a Constants class. It could alternatively be supplied through the XML file and put into the MessageCodes class as a static constant. I think the best name for it would be: MessageCodes.BUNDLE

Should be able to do a regex ignoring case without having to build that into the expression; Java RE has a flag for this right?