krzysztofzablocki / traits Goto Github PK

AFAIK, UIAppearance uses proxy objects, so we can't just set trait specs for them.

Here is what I had to do to make it work with UIAppearance.

1. Disable restrictedTypes check (can't add private _UIAppearance type to the list)
2. Use unsafeBitCast instead of force cast on target objects (force cast traps while trying to cast _UIAppearance to something else)
3. Re-add root UIViews for all UIWindows after traits are reloaded (so that the changes in UIAppearance take effect).
   Maybe there is a better way to accomplish it.

The first two hacks are very dirty, but we could try to wrap them in an abstration.
We could introduce something like 'TypeCastingStrategy' and use different implementations for normal objects and UIAppearance proxies.

The hack with re-adding UIViews seems simple and working, but there could be some downsides I'm not aware of.

What do you think about this? Is support of UIAppearance worth hacking?
I could try to make a prototype :)

Hi,
For iOS projets it's will be great to make your component Carthage compatible

Take a look at these articles:

• Ruthlessly Simple Dependency Management with Carthage
• Carthage Tutorial: Getting Started
• Making Carthage-compatible Frameworks with Swift
• Swift Cross Platform Framework (section Configure targets for Carthage) 👍

On your README.md add on top and add section for the installation with Carthage.

Hi author, how to use this in OC project? Thanks. Newbie is me, haha^-^.

Hi,

if i have to define a TraitIdentifierEntry for each property of each object, just like follow:

private var entry: TraitIdentifierEntry {
    switch self {
    case .containerView:
        return TraitIdentifierEntry("containerView", classes: [UIView.self])
    case .backgroundView:
        return TraitIdentifierEntry("backgroundView", classes: [UIView.self])
    case .titleLabel:
        return TraitIdentifierEntry("titleLabel", classes: [UILabel.self])
    case .childView:
        return TraitIdentifierEntry("childView", classes: [UIView.self])
    case .childViewWidth:
        return TraitIdentifierEntry("childView.width", classes: [NSLayoutConstraint.self])
    case .childViewHeight:
        return TraitIdentifierEntry("childView.height", classes: [NSLayoutConstraint.self])
    case .titleLabelLeading:
        return TraitIdentifierEntry("titleLabel.leading", classes: [NSLayoutConstraint.self])
    case .titleLabelTop:
        return TraitIdentifierEntry("titleLabel.top", classes: [NSLayoutConstraint.self])
    }
}

Hi,Author, is there one version can work on Objective-C? I think it's a nice idea. Thanks

As I understand, if I want Font trait to support UITextView I have to modify Font source code: add UITextView.self to restrictedTypes array and modify apply method.

IMO, if target type restrictions were expressed via a protocol, it would be easier to add new target classes to existing traits.