kristianoellegaard / cmsplugin-text-ng Goto Github PK

AppRegistryNotReady

This will stop us from upgrading the project to Django 1.7 which is the latest stable release, or we have to drop cmsplugin-text-ng :(

It would make a lot of sense to have the templates defined in a setting, not in the database:

• Less SQL queries
• To add templates, one needs to update the template folder anyway (server restart, deployment etc) so no real reason to have it in the db
• The DB backed solution is more prone to errors (renaming templates, typo in template path, ....)
• Makes deployment harder, since after adding a template one has to log into admin and add the template there

Your documentation says

"Create some templates (more on that soon) and add them in the admin."

You put the examples of the templates but I don't know where to add the files. I tried all sorts combinations of templates, admin and cmsplugin-text-ng; but the selector of the template is always empty

{{ form_url }} is not set in the change_form template

The define template tag would be useful as classy-tag, so it can be subclassed. agreed?

In general the idea for having template-backed plugin with input fields seems nice, but if you look at it from a distance you see, that you are doing the same thing on the "content"-level as django-cms is doing on the "page"-level (select a template and put plugins/input fields in it). From this point of view it seems that the plugin is trying to reinvent something pretty similar django-cms already has and it would probably be better to reuse it's functionality... Think about it.

Anyway I would like to point out that the plugin could be redesigned to be a simple template layer that would allow to have slots in which subplugins could be inserted. Just like the text plugin can insert a link plugin, this template plugin could insert one or more text, image and other plugins. This way funcionality of plugins wouldn't be duplicated and each one could reused and improved to do it's job well (DRY principle).