Fatality of uncaught exceptions in NodeJS about asap HOT 8 CLOSED

I might be misunderstanding, but the readme seems perfectly accurate to me. In particular,

when the underlying JavaScript engine will treat it as it does any unhandled exception

seems to exactly match what asap does.

from asap.

I do not think that the README is inaccurate, but I do agree that we should clarify what “as it does any unhandled exception” means for NodeJS, specifically with regard to our respect for domains.

from asap.

@domenic that part is fine, it's the rest that is untrue:

If a task throws an exception, it will not interrupt the flushing of high-priority tasks. The exception will be postponed to a later, low-priority event to avoid slow-downs, when...

from asap.

Oh hmm, looking at the code, you're right:

https://github.com/kriskowal/asap/blob/master/asap.js#L30-L47

Weird.

from asap.

I don't have a strong opinion on which behavior is better, as I'm still holding out hope for removing all exception handling from asap.

from asap.

Oh, I see. Yeah, that’s different.

from asap.

ASAP is already at version 1.0.0, and I think documentation should correctly reflect the current state of the code. Apparently there will not be a consensus very soon, so I think we should fix the paragraph as soon as possible, and to revert it in future if needed. I am going to create a new branch for that.

from asap.

It seems I forgot to close this one.

from asap.