Browserify Support about asap HOT 15 CLOSED

I'm attempting to use https://github.com/Khan/aphrodite in a project that I'm building with https://github.com/fuse-box/fuse-box

The browser mapping doesn't seem to work with fuse-box (it works for the entry point, but not the other internal modules, such as raw).

The only way I can make this work is by changing:

var rawAsap = require("./raw");

to

var rawAsap = require("./browser-raw");

in browser-asap.js.

from asap.

This is perplexing since ASAP already has these redirects in its own package.json.

from asap.

Yes, it was strange. Note that I did modify the ASAP package.json to specify the file paths (./asap.js as opposed to asap as indicated above) in my local clone of ASAP and that did fix the problem for browserify. If I made these modifications to ASAP package.json, no changes were required for my requiring module.

from asap.

Ah, that rings a bell. Browserify is picky about such things.

from asap.

Committed a change to master. Unfortunately, this broke the build tooling, which says less about ASAP and more about Mr v2, I expect.

from asap.

Probably related: browserify/browserify#1119

from asap.

I published the asap-browser package to NPM to work around this issue for now. It's the same as asap with kevinbeaty's changes applied (main is now browser-asap.js, and browser-asap.js requires browser-raw).

from asap.

@agentme Note above that I committed and published fixes for Browserify. Please confirm that these were not sufficient.

from asap.

Your changes in ASAP did not fix the issue for me. I've been getting inconsistent behavior from Browserify, so I think it's a Browserify bug. I've seen the following combinations of things end up in the browserified bundle: asap.js and browser-raw.js, browser-asap.js and raw.js, and asap.js and raw.js.

from asap.

The problem also occurs with webpack.
Modifying package.json as pointed out by @kevinbeaty solves it for me.

"browser": {
  "./asap.js": "./browser-asap.js",
  "./raw.js": "./browser-raw.js",
  "./test/domain.js": "./test/browser-domain.js"
}

I don't know if the browser field is properly defined somewhere.
The only source I could find is https://gist.github.com/defunctzombie/4339901/49493836fb873ddaa4b8a7aa0ef2352119f69211#replace-specific-files---advanced which shows that the keys under the browser field should be relative paths apparently including the file extension.

from asap.

@ewie. Sending a fix up now.

from asap.

@kriskowal. Damn you're quick 😄. I was just preparing a PR.

from asap.

I do my github gardening on Saturdays. I’ve pushed a patch release. I verified locally that it works with Browserify, but as always, mileage will vary. Please let me know if there are further problems.

from asap.

@kriskowal. I guess you mean release 2.0.1. That doesn't solve the problem for webpack. As I wrote in my first comment you probably have to specify the browser field in terms of relative file paths (including the file extensions which are missing from the keys in 588bb88).

from asap.

@ewie I mean 2.0.2, which I forgot to push. Fixed.

from asap.