Does this work with continuation-local-storage about asap HOT 5 CLOSED

This is new to me. ASAP does play the domains game though, so I would not be surprised whether continuation storage worked or not. Please follow-up if you can. If we don’t have to entrain a dependency, and with good specs, I would not mind supporting it at least to the extent that it is an experiment worth trying.

from asap.

Here is what it would take to make asap CLS-aware (replacing the current definition of the asap function):

function asap(task) {
    if (isNodeJS && process.domain) {
        task = process.domain.bind(task);
    }

    if (isNodeJS && process.namespaces) {
        var namespaces = Object.keys(process.namespaces);
        var length = namespaces.length;
        for (var i = 0; i < length; i++) {
            if (namespaces[i].active) task = namespaces[i].bind(task);
        }
    }

    tail = tail.next = {task: task, next: null};

    if (!flushing) {
        requestFlush();
        flushing = true;
    }
};

@ForbesLindesay It also would be fairly simple to write a shim module that wraps around asap (there are a bunch of CLS shims already) if you don't see the value of making asap support something that isn't part of Node core:

require('continuation-local-storage');
var asap = require('asap');

module.exports = function clsAsap(task) {
    if (process.namespaces) {
        var namespaces = Object.keys(process.namespaces);
        var length = namespaces.length;
        for (var i = 0; i < length; i++) {
            if (namespaces[i].active) task = namespaces[i].bind(task);
        }
    }

    return asap(task);
}

For now, CLS is Node-only, so I'm not really sure how much value you get out of using asap over setImmediate, but this is how you make it play nice with CLS!

from asap.

Oh, and I should point out that I already made a shim for Q which is only really necessary when you're using some other module that messes with continuation chains (like node-redis or node-mysql).

from asap.

With apologies, my inclination is to not do anything special for this kind of extension.

from asap.

Thanks, that seems fair. I may revisit this and consider producing something like asap-cls if I find myself really needing it.

from asap.