Missing browserify dev dependency about asap HOT 5 CLOSED

The obvious fix would be to add browserify in dev dependency.
However, browserify is not a small dependency, and I suppose it is usually installed globally.
Since browserify is not required in travis-ci, I would rather avoid to use it there.

To accomplish that, we could change the the test name from pretest to something like build-for-browsers.
However, this would make necessary to run npm run build-for-browsers every time we are going to test in browsers. This is too easy to forget.

Changing the pretest script to:

[ -z "$TRAVIS" ] && browserify asap.js -s asap -o build.js

would work, but not in every environment.

As a possible solution, we could explicitly define the script to run in travis by appending:

script:
  - "mocha -s 200 test/test.js"

to .travis.yml.

Ideas?

from asap.

However, browserify is not a small dependency, and I suppose it is usually installed globally.

This is not really how it should work. If something is used for development, and indeed required to run the tests, it should be a dev dependency. You should never have these things installed globally, because then you might use the wrong version on a given project. You should always use a project's local versions of its build tools to build that project.

Since browserify is not required in travis-ci, I would rather avoid to use it there.

But browserify is required in testling-ci.

As a possible solution, we could explicitly define the script to run in travis by appending:

I think the way it is now is fine, but something like this could work too. I'd do it the other way around; define npm run test-node-only and npm run test-browsers-only, then have Travis trigger npm run test-node-only.

from asap.

Ok to leave browserify in dev dependency, but would still like to not use it in travis.

I'd do it the other way around; define npm run test-node-only and npm run test-browsers-only, then have Travis trigger npm run test-node-only.

I like this, but without test-browsers-only, since it would require an opener or something, and that would only complicate testing in multiple browsers (?).

from asap.

Ok to leave browserify in dev dependency, but would still like to not use it in travis.

Why, if you don't mind me asking? It gives us good coverage to see if users can successfully browserify asap!

from asap.

Hmm, good point. Ok as it is then :)

from asap.