kreshuklab / bioimg_rs Goto Github PK

Eg:

    let bad_rdf = Rdf {
        format_version: Version {
            major: 1,
            minor: 2,
            patch: 3,
        },
        description: "".try_into().unwrap(),
        name: "".try_into().unwrap(),

        attachments: None,
...

As in your test, modified with bad string values... But this passes the compiler fine as it's the unwrap that will fail at runtime.

Eg a test program using this gives:

warning: `bioimg_spec` (lib) generated 2 warnings (run `cargo fix --lib -p bioimg_spec` to apply 1 suggestion)
   Compiling third_party v0.1.0 (/home/jeremy/documents/kth/bioimg_rs/third_party)
    Finished dev [unoptimized + debuginfo] target(s) in 1.54s
     Running `target/debug/third_party`
I'm a Rust coder hard coding an RDF...
thread 'main' panicked at third_party/src/main.rs:13:36:
called `Result::unwrap()` on an `Err` value: BadLength { value: "", allowed: 1..=1024 }

Seems unlikely that there should be workspace-level dependencies - see https://github.com/kreshuklab/bioimg_rs/blob/master/Cargo.toml#L7

When looking into the feasibility of this recently, I came across eg

• validator - https://crates.io/crates/validator
• garde - https://crates.io/crates/garde
• serde_valid - https://crates.io/crates/serde_valid

Perhaps it would make more sense to use one of these for the "easy" fields and only worry about the more complicated validation logic ourselves - or is there a reason not to?

to save incomplete work