krazylabs / react-native-app-settings Goto Github PK

when rm -rf node_modules && npm i in my rn project. The step extract:react-native-app-settings always takes several minutes. Is this expected?

When using pod install this pod gives the following error

The RNOpenAppSettings pod failed to validate due to 1 error:
- ERROR | attributes: Missing required attribute homepage.
- WARN | source: The version should be included in the Git tag.
- WARN | description: The description is equal to the summary.

Solution: add https://github.com/KrazyLabs/react-native-app-settings to s.homepage value

Hello, would it be possible to get a new version onto NPM ? Would be great 🎉

Hi,

I am install new package version but this warning is not gone. Please tell me how to solve this. If I have change custom, but reinstall the npm, this warning is again occur.
Here version is "react-native-app-settings": "^2.0.1",

Please update the Readme to state that manual installation involves editing MainApplication.java (not MainActivity.java).

And implementation instead of compile.

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-app-settings/android/build.gradle b/node_modules/react-native-app-settings/android/build.gradle
index 849e79a..f87bfa7 100644
--- a/node_modules/react-native-app-settings/android/build.gradle
+++ b/node_modules/react-native-app-settings/android/build.gradle
@@ -31,6 +31,6 @@ repositories {
 }
 
 dependencies {
-    compile 'com.facebook.react:react-native:+'
+    implementation 'com.facebook.react:react-native:+'
 }
   
\ No newline at end of file

This issue body was partially generated by patch-package.

Hello,

Could you kindly increment the version of the package to 2.0.1 (remember to update also to run the npm publish)??
Otherwise we can not use the library with CocoaPods.

Thanks

Hi, i found a error in react native version 0.58.6
and android buildToolsVersion = "28.0.3"

• What went wrong:
  Execution failed for task ':react-native-app-settings:verifyReleaseResources'.

java.util.concurrent.ExecutionException: com.android.builder.internal.aapt.v2.Aapt2Exception: Android resource linking failed
Output: /Users/gh.mbp974/Documents/DEV_SITE/streego/streego/node_modules/react-native-app-settings/android/build/intermediates/res/merged/release/values-v28/values-v28.xml:7: error: resource android:attr/dialogCornerRadius not found.
/Users/gh.mbp974/Documents/DEV_SITE/streego/streego/node_modules/react-native-app-settings/android/build/intermediates/res/merged/release/values-v28/values-v28.xml:11: error: resource android:attr/dialogCornerRadius not found.
/Users/gh.mbp974/Documents/DEV_SITE/streego/streego/node_modules/react-native-app-settings/android/build/intermediates/res/merged/release/values/values.xml:957: error: resource android:attr/fontVariationSettings not found.
/Users/gh.mbp974/Documents/DEV_SITE/streego/streego/node_modules/react-native-app-settings/android/build/intermediates/res/merged/release/values/values.xml:958: error: resource android:attr/ttcIndex not found.
error: failed linking references.

The sdk version of this package need to be increased to support newer react native versions.

Refer Pull request: #10

i know this is out of your hands, but what you built is exactly what my app needs, and quite frankly, what most apps need (when considering holistic UX)

https://expo.canny.io/feature-requests/p/auto-link-to-apps-settings-cross-platform-for-apps-notificationlocationservices-

hopefully it gets voted up!!!

One idea of making the library more customizable is to allow the user to pass the custom settings tab that he wishes to open by parameter.

For example:

• open the general settings
  OpenAppSettings.open("settings")

• open notification settings
  OpenAppSettings.open("notifications")

• open the storage settings
  OpenAppSettings.open("storage")