kraison / cl-skip-list Goto Github PK

Building with SBCL 2.1.6 / ASDF 3.3.1 for quicklisp dist creation.

Trying to build commit id db45fc8

cl-skip-list fails to build with the following error:

Unhandled TYPE-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING {1001A18103}>: The value * is not of type LIST

Full log here

If you want, seems this could be ported to Franz ACL (and probably others).

In ACL you have

• Barriers: https://franz.com/support/documentation/current/doc/smp.htm#barrier-api-2
• cas: https://franz.com/support/documentation/current/doc/operators/excl/atomic-conditional-setf.htm
• object address: internal function excl::pointer-to-object

I am using SBCL 2.1.9 on macOS Monterey (Apple M1) and there is an error in loading the file skip-list.lisp during macroexpansion of DEFSTRUCT SKIP-LIST.

; in: DEFSTRUCT SKIP-LIST
;     (DEFSTRUCT
;         (CL-SKIP-LIST::SKIP-LIST (:PREDICATE CL-SKIP-LIST:SKIP-LIST?)
;          (:PRINT-FUNCTION CL-SKIP-LIST::PRINT-SKIP-LIST))
;       (CL-SKIP-LIST::HEAD (CL-SKIP-LIST::MAKE-HEAD))
;       (CL-SKIP-LIST::KEY-EQUAL #'EQUAL)
;       (CL-SKIP-LIST::VALUE-EQUAL #'EQUAL)
;       (CL-SKIP-LIST::COMPARISON #'CL-SKIP-LIST:LESS-THAN)
;       (CL-SKIP-LIST::DUPLICATES-ALLOWED? NIL)
;       (CL-SKIP-LIST::NODE-FN #'CL-SKIP-LIST::MAKE-SKIP-NODE)
;       (LENGTH 0 :TYPE))
; 
; caught ERROR:
;   (during macroexpansion of (DEFSTRUCT (SKIP-LIST # ...) ...))
;   Error while parsing arguments to DESTRUCTURING-BIND:odd number of elements in keyword/value list: (:TYPE)

The reason is that #+CFFI-FEATURES:X86-64 is no longer in *features*. Instead #+ARM64 (UNSIGNED-BYTE 64)should be added as an additional option to the type initialisation of the lengthslot. Could you please fix this so I can load cl-skip-list through quicklisp again (now I have my local copy). Thanks a lot!

I tried building this project for Quicklisp on a 32-bit system, and it barfed on the declaration of the length as an (unsigned-byte 64). For 32-bit systems, it has to be (unsigned-byte 32).

random.lisp has this:

(cerror "STATE should not have a value of ~A")

There's no corresponding argument to the cerror format control string. This causes a full warning on SBCL and it fails to load as a result.