Git Product home page Git Product logo

macs's People

Contributors

05nelsonm avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

macs's Issues

`Hmac` should blank `preparedKey` after deriving `iKey` and `oKey`

Current implementation of Hmac.Engine is that the provided key ByteArray is sized to the digest.blockSize() by either hashing it once (if larger than), padding it with 0's (if smaller), or using the provided key. It then uses the prepared key to derive iKey and oKey.

After those are derived, the preparedKey should be blanked. As such, the provided key should always be copied so we are not modifying the provided ByteArray, so that the copy can be blanked before dereferencing.

val preparedKey = if (key.size > digest.blockSize()) {
    digest.digest(key).copyOf(digest.blockSize())
} else {
    key.copyOf(digest.blockSize())
}

// ... derive iKey and oKey

preparedKey.fill(0)

Remove `hmac-sha2-256` and `hmac-sha2-512` modules

For release 0.3.0, modules hmac-sha2-256 and hmac-sha2-512 will no longer be published. They were there for supporting backward compatibility with consumers of 0.1.X versions and will be going away as there has been ample time to heed the deprecation notice.

Rework dependencies to use implementation

Currently, dependencies are expressed as api for core digest, and digest algos. The high level implementations of Hmac algos should not provide this dependency. If the consumer wishes to import the hashing algo, they can do so themselves. The only core libs that should be provided is mac and common (b/c needed).

Improve `KMAC` performance

Kmac.Engine currently only uses Xof for CSHAKE as its hashing source. There is a lot of unnecessary overhead with this when used as a Mac. As such, Kmac.Engine should be split into 2, DigestEngine, and XofEngine.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.