Git Product home page Git Product logo

Comments (8)

altavir avatar altavir commented on May 27, 2024 5

The workaround is to add api(npm("text-encoding")) to JS platform dependencies. It gives a warning about unmaintained dependency, but works.

from kotlinx-io.

dhakehurst avatar dhakehurst commented on May 27, 2024 1

me too.
Thanks to @altavir for the work-around tip.
I find that I solved this in two parts,
for the browser,
add to package.json

"browser": {
    "text-encoding": false,
    "ws": false,
    "fs": false,
    "path": false,
    "os": false,
    "crypto": false,
    "stream": false,
    "http": false,
    "tls": false,
    "zlib": false,
    "https": false,
    "net": false
  }

then for the tests (which fail also with this problem)

kotlin {
    sourceSets {
        val jsTest by getting {
            dependencies {
                api(npm("text-encoding"))
            }
        }
    }
}

from kotlinx-io.

gincwang avatar gincwang commented on May 27, 2024 1

nvm I got it working with this syntax for groovy

jsMain {
    dependencies {
        implementation npm("text-encoding", 0.7.0)
    }
}

from kotlinx-io.

JesseCorbett avatar JesseCorbett commented on May 27, 2024

I'm running into this issue as well. It's resulting in ktor-js being entirely unusable for me. Any odds we can see this issue addressed soon?

from kotlinx-io.

Ribesg avatar Ribesg commented on May 27, 2024

Just encountered this as well!

from kotlinx-io.

gincwang avatar gincwang commented on May 27, 2024

Hello I'm trying to add this to my gradle (in groovy) but it's not recognizing the npm command, is that another plugin we have to add? Could not get unknown property 'npm' for object of type org.jetbrains.kotlin.gradle.plugin.mpp.DefaultKotlinDependencyHandler

from kotlinx-io.

joffrey-bion avatar joffrey-bion commented on May 27, 2024

I had the same issue and added the npm() dependency. It solved the problem, but the warning is a bit annoying.

I actually found out that my own mutliplatform libraries don't publish their npm dependencies either, and require the users to add the npm dependencies to their gradle files just like this.

Is it a gradle plugin issue or should it be fixed in the library?
Any idea how this should be fixed on library side?

from kotlinx-io.

fzhinkin avatar fzhinkin commented on May 27, 2024

We're rebooting the kotlinx-io development (see #131), all issues related to the previous versions will be closed. Consider reopening it if the issue remains (or the feature is still missing) in a new version.

from kotlinx-io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.