Comments (3)
05nelsonm
commented on June 24, 2024
1
Completely understandable if it was internal, but it is a part of the public API. Anyone from commonMain relying on SystemPathSeparator would "assume" that it delegates to the actual system path separator (like Jvm and Js are doing).
If nativeMain is in conflict with the actual system's path separator, why not drop the expect/actual and define SystemPathSeparator in commonMain as /?
from kotlinx-io.
fzhinkin
commented on June 24, 2024
That was done intentionally as Windows should correctly handle both \ and / as path separators (/ are canonicalized to \) and using / as the separator seemed an easier option.
Are there any cases where it works incorrectly? Or it's mostly about SystemPathSeparator itself being non-canonical for Windows?
from kotlinx-io.
fzhinkin
commented on June 24, 2024
I'll address the issue in scope of #241.
from kotlinx-io.
Related Issues (20)
- Provide linuxArm32Hfp target HOT 2
- Make functions to read and write code points public
- Validate UTF-8 encoding/decoding correctness
- Make sure current API could be later extended to support charsets other than UTF-8
- Better segment pools HOT 8
- Find workaround for WASI's fd_readdir unsupported on NodeJS@Windows HOT 5
- Filter intermediate source sets out of generated documentation
- Consider alternative Sink.writeString implementations on JVM
- Move kotlinx.io.files package to a separate module
- Float reading and writing is inconstent on Kotlin JS HOT 4
- Add an option to throw an exception from Source.readString decoding errors
- Provide extensions to read/write unsigned byte arrays
- ERROR: SystemFileSystem.list() Unresolved reference 'list'. HOT 5
- Symlink features are missing HOT 2
- Wasm WASI: use linear memory as segments backing storage
- Move some of Sink/Source member functions to extensions
- Switch from Yarn to npm package manager HOT 2
- support FakeFileSystem HOT 2
- Optimize performance of extension functions defined on Source when called on a Buffer
- (System)FileSystem::source Throws FileNotFoundException For Permissions Issues HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kotlinx-io.