Comments (3)
05nelsonm
commented on June 16, 2024
1
Completely understandable if it was internal, but it is a part of the public API. Anyone from commonMain relying on SystemPathSeparator would "assume" that it delegates to the actual system path separator (like Jvm and Js are doing).
If nativeMain is in conflict with the actual system's path separator, why not drop the expect/actual and define SystemPathSeparator in commonMain as /?
from kotlinx-io.
fzhinkin
commented on June 16, 2024
That was done intentionally as Windows should correctly handle both \ and / as path separators (/ are canonicalized to \) and using / as the separator seemed an easier option.
Are there any cases where it works incorrectly? Or it's mostly about SystemPathSeparator itself being non-canonical for Windows?
from kotlinx-io.
fzhinkin
commented on June 16, 2024
I'll address the issue in scope of #241.
from kotlinx-io.
Related Issues (20)
- Path.parent doesn't work with default Windows path separator
- Support listing files in a directory Path HOT 4
- Support getting a canonical file Path HOT 2
- Evaluate and tune Segment::compact behaviour
- Support read-only views with random-access capability
- Support encodings other than UTF-8 and support BOM handling HOT 2
- Update Kotlin to 1.9.20
- Random access to files HOT 2
- Add permissions to FileMetadata HOT 2
- Add SystemFileSystem.copy() HOT 4
- Support Wasm Wasi target
- Problems when creating own implementation of RawSink/RawSource HOT 2
- Support ByteBuffer as a backing storage on JVM HOT 8
- Files and FileSystems support HOT 3
- Add benchmarks targeting kotlinx.io.Source methods and extensions
- `Path.parent` for Native returns null for space-only parent directory HOT 1
- Reuse allcocated arrays HOT 2
- SystemFileSystem.sink does not create empty file on NodeJs target HOT 1
- Cannot get position from Source HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kotlinx-io.