Git Product home page Git Product logo

lassy-tlg-supertagging's People

Contributors

konstantinoskokos avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

jakpra

lassy-tlg-supertagging's Issues

possible bug in train_epoch and eval_epoch

When reporting loss, in train_epoch, the code says
batch_p = self.forward(batch_x, batch_e, encoder_mask, decoder_mask)

However in eval_epoch "infer"
batch_p = self.transformer.infer(batch_x, encoder_mask, dataset.type_dict['<SOS>'])

For Transformer.infer and Transformer.forward, the returned values diff by a torch.log operation

in infer_one(), we have

prob_t = self.predictor(decoder_step[:, -1])
return self.activation(prob_t)

However, in forward

prediction = self.predictor(decoder_output.decoder_input)
return torch.log(self.activation(prediction))

Therefore, the batch loss in both train_epoch and eval_epoch is computed by

batch_loss = criterion(batch_p[:, :-1].permute(0, 2, 1), batch_y[:, 1:])

may not be comparable for train_epoch and eval_epoch?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.