Store HTTP header names in lower case about unirest-java HOT 5 CLOSED

One solution would be to use Apache Commons Collections Case Insensitive Map for storing headers. However that'd increase the dependency footprint. In any case here is a link:

https://commons.apache.org/proper/commons-collections/apidocs/org/apache/commons/collections4/map/CaseInsensitiveMap.html

from unirest-java.

This is a real problem for me too, different APIs return different cases for the headers. Something like that should work:

public class CaseInsensitiveMap extends HashMap<String, String> {

    @Override
    public String put(String key, String value) {
       return super.put(key.toLowerCase(), value);
    }

   public String get(String key) {
       return super.get(key.toLowerCase());
    }
}

from unirest-java.

I think a cleaner solution is to use

Map<String, List<String>> headers = new TreeMap<String, List<String>>(String.CASE_INSENSITIVE_ORDER);

from unirest-java.

Yep gets the job done either way, headers are few enough so the perf difference between tree and hash map is irrelevant. Thanks for the fix.

from unirest-java.

I will push it to the Maven Central Repository soon in a new minor version.

from unirest-java.