Git Product home page Git Product logo

Comments (10)

ryber avatar ryber commented on July 23, 2024 1

Yea Maven central is a maze, the artifacts will typically show up for download in under 1 hour (I assume there is some cache that needs to expire), the website updates about once per day.

As for the per-request. We can just leave this issue open. But what I would like to understand is the reason folk would want to do that? It was my understanding (probably wrong) that HTTP2 was backwards compatible and degraded gracefully to 1.1. You would think the extra headers would just be ignored. What happened that caused you to even look at this?

from unirest-java.

ryber avatar ryber commented on July 23, 2024 1

Oh good, I think we can close this then if it works for you

from unirest-java.

JamesBoon avatar JamesBoon commented on July 23, 2024

In addition, it would be very practical if the version could be set individually for each request.
Just like this:

HttpResponse<String> response = Unirest.post("https://httpbin.org/post")
        .version(HttpClient.Version.HTTP_1_1)
        .body("test body")
        .asString();

Should I create a new feature request for this?

from unirest-java.

ryber avatar ryber commented on July 23, 2024

just released 4.2.5 with this fix. I just did the root config for now, per request is a but more work.

from unirest-java.

JamesBoon avatar JamesBoon commented on July 23, 2024

Thank you! The commits look good.
What do you think, how long will it take until 4.2.5 will be available in Maven Central? EDIT: It is available - just not visible on the webpage 🙄

And should I create a new feature request for the "per request" configuration? Or do you find that feature (request) unnecessary?

from unirest-java.

JamesBoon avatar JamesBoon commented on July 23, 2024

I have to make calls to an old legacy server that denies access as soon as I send the http2 headers. (Don't ask me why!)
It was actually a bit of a pain to find the cause for this behavior 😅

from unirest-java.

JamesBoon avatar JamesBoon commented on July 23, 2024

Seriously, @ryber, this is amazing. I just came here and thought I would ask you if you need any help with the implementation, like creating a PR.
And now you're already done!

from unirest-java.

ryber avatar ryber commented on July 23, 2024

I'm trying to figure out if it actually deployed, maven central threw a weird error at the very end after it uploaded the artifacts. Its kind of a mess

from unirest-java.

JamesBoon avatar JamesBoon commented on July 23, 2024

It seems it worked: https://repo1.maven.org/maven2/com/konghq/unirest-java-core/4.2.6/

from unirest-java.

JamesBoon avatar JamesBoon commented on July 23, 2024

It works perfectly!

from unirest-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.