MockResponse does not work with Unirest 4 anymore about unirest-java HOT 7 CLOSED

MockResponse is valid as a utility, people can use it in classes with methods that take a HttpResponse for example, it is not, as noted, intended to be used with the mock client.

You are not the first person to think this, and I think its reasonable to expect that if people think it should work some way, then maybe it should.

I'm intrigued that it EVER worked at least

from unirest-java.

Hi @ryber, I was not aware of that use case for MockResponse which makes sense. And I like the fluent API, too.

In fact, the response worked in Unirest 3. I just came around this problem when updating my source to Unirest 4 and suddenly the test failed.

from unirest-java.

I'm actually going to re-open this temporarily because I'm making it work again. but I'm having a maven central problem and have a ticket open with SonaType, I want to keep this open until I get it all resolved

from unirest-java.

ready to go in 4.0.7 @timomeinen

from unirest-java.

Tested it and it works again. Thank you @ryber. On the other side as I now know the fluent API I will use that one. ;-)

from unirest-java.

HI @ryber,

today I realized that the provided fix does not work correctly for the statusText:

            unirestMock.expect(HttpMethod.GET, HEALTH_URL)
                    .thenReturn(MockResponse.bad("Fail"));

            HttpResponse<Empty> response = Unirest.get(HEALTH_URL).asEmpty();
            assertThat(response.getStatus()).isEqualTo(400);
            assertThat(response.getStatusText()).isEqualTo("bad request"); // FAIL: No statustext

But using the fluent API works as expected:

            unirestMock.expect(HttpMethod.GET, HEALTH_URL)
                    .thenReturn("Fail")
                    .withStatus(400, "bad request");

Although the kong.unirest.core.MockResponse does set a statustext:

public static <T> MockResponse<T> bad(T body) {
    return new MockResponse<>(400, "bad request", body);
}

from unirest-java.

@timomeinen fixed in 4.1.1

from unirest-java.