Git Product home page Git Product logo

meteor-magnific-popup's Introduction

MagnificPopup plug-in for jQuery

Light and responsive lightbox script with focus on performance - Automated Smart Package for Meteor

Latest Version - GUARANTEED

This Atmosphere Smart Package for Meteor is automatically updated with the latest commit of the vendor repository every few hours.

Every new release from the vendor is also automatically tagged in this repository and published to Atmosphere.

meteor-magnific-popup's People

Contributors

engelgabriel avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

meteor-magnific-popup's Issues

Hello there,

check out rocket:module. It will share magnific-popup from NPM with all the Meteor packages of a given Meteor application at the same time so you don't have to wrap magnific-popup from NPM inside of your gabrielengel:konecty-magnific-popup package.

This reduces the amount of maintenance that you need to do to publish new versions of magnific-popup by 100%, while affording other Meteor package developers the freedom to use other NPM packages that may also depend on magnific-popup from NPM.

There's no way you'd want to wrap all the NPM packages that depend on magnific-popup from NPM into your gabrielengel:konecty-magnific-popup package.

rocket:module allows for Meteor packages to get and share external libraries from NPM, avoiding the pollution of the Atmosphere caused by Meteor packages that depend on the same NPM packages. Meteor's default behavior is to compile, save, and store an NPM package into each Meteor package during publication of the Meteor packages onto Atmosphere.

For example, if 10 Meteor packages in your application depend on 10 libraries from NPM, and those 10 NPM libraries all depend on React from NPM, then your application now has 10 copies of the React library...

That's 10 singleton React objects in your application.

React isn't meant to be used that way. That's way worse than having 10 versions of jQuery running in the same application: $, $1, $2, $3, $4, $5, $6, $7, $8, $9, and $10.

To help the cause, use rocket:module to specify all your NPM dependencies. Once you've done that, rocket:module will handle the sharing of those NPM modules across your app's Meteor packages.

It does not work on current version

meteor add gabrielengel:konecty-magnific-popup

I used the command before to add the package, however, the browser report "magnificPopup undefined" when I click.

I have checked the sources in developer mode, and the package actually was there.

I am not sure the problem is caused by loading order?

I fixed the problem by adding it in the old way:

  1. download the package from offical website.
  2. copy it to project folder
  3. add it by <script src="js/jquery.magnific-popup.js"></script>

Installation problem - required file not in git?

$ mrt add magnific-popup
โœ“ magnific-popup
tag: https://github.com/Konecty/meteor-magnific-popup.git#v0.9.11+170e942
ERROR: 1 Command failed: error: pathspec 'v0.9.11+170e942' did not match any file(s) known to git.

STDOUT:

STDERR: error: pathspec 'v0.9.11+170e942' did not match any file(s) known to git.

/usr/local/lib/node_modules/meteorite/lib/sources/git.js:181
self.checkoutType + ": " + (self.commit || self.head);
^
There was a problem checking out tag: v0.9.11+170e942

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.