kogg / instantlogosearch Goto Github PK
View Code? Open in Web Editor NEWThe fastest way to find logos from hundreds of brands, startups, and companies.
Home Page: http://instantlogosearch.com/
The fastest way to find logos from hundreds of brands, startups, and companies.
Home Page: http://instantlogosearch.com/
Do this how @cameronrohani and @saiichihashimoto discussed (will put that in here, just busy right now). Then we can do #22 properly.
By Downloads or Searches? Or both?
When users suggest logos with non-american characters (ex. tildes, japanese) they receive a 400: Bad Request
. This should be allowed.
View details in Rollbar: https://rollbar.com/instantlogosearch/instantlogosearch/items/10/
Error: 400: Bad Request
File "Suggestions.js", line 9, in <unknown>
File "node.js", line 357, in process._tickCallback
It only works on @saiichihashimoto's computer and not even uploading an image.
View details in Rollbar: https://rollbar.com/instantlogosearch/instantlogosearch/items/2/
Error: Width or height could not be determined from either the source file or the supplied dimensions
File "/app/node_modules/svg2png/lib/svg2png.js", line 52, in processResult
throw new Error(stdout.replace(/\r/g, "").trim());
View details in Rollbar: https://rollbar.com/instantlogosearch/instantlogosearch/items/11/
Error: request entity too large
File "/app/node_modules/body-parser/node_modules/raw-body/index.js", line 196, in readStream
return done(createError(413, 'request entity too large', 'entity.too.large', {
File "/app/node_modules/body-parser/node_modules/raw-body/index.js", line 106, in getRawBody
return readStream(stream, encoding, length, limit, done)
File "/app/node_modules/body-parser/lib/read.js", line 76, in read
getBody(stream, opts, function (err, body) {
File "/app/node_modules/body-parser/lib/types/json.js", line 121, in jsonParser
read(req, res, next, parse, debug, {
File "/app/node_modules/feathers/node_modules/express/lib/router/layer.js", line 95, in Layer.handle [as handle_request]
fn(req, res, next);
File "/app/node_modules/feathers/node_modules/express/lib/router/index.js", line 312, in trim_prefix
layer.handle_request(req, res, next);
File "/app/node_modules/feathers/node_modules/express/lib/router/index.js", line 280, in <unknown>
trim_prefix(layer, layerError, layerPath, path);
File "/app/node_modules/feathers/node_modules/express/lib/router/index.js", line 330, in Function.process_params
return done();
File "/app/node_modules/feathers/node_modules/express/lib/router/index.js", line 271, in next
self.process_params(layer, paramcalled, req, res, function (err) {
File "/app/node_modules/compression/index.js", line 218, in compression
next();
When we have permalinks/SEO figured out, we're going to have to:
Nothing goes to download and the zips don't work
We're logging things with a debugger (which is good), but we also want to log things into PaperTrail. The console is synchronous; we need to use a different solution.
http://expressjs.com/en/advanced/best-practice-performance.html#for-app-activity
It'll make things smaller to not include a new library.
@cameronrohani: When downloading a logo, it might take some time. It's super weird to hit the button... and nothing happens. During that time, we should show some kind of animation.
We can't do this whatsoever in Safari and we can only do it in other browsers for the zips. This won't be difficult. @saiichihashimoto can add a class for @cameronrohani to mess with.
Bonus: The popup should only show after that time. Again, only possible in those specific instances.
Downloading the PNGs as a zip doesn't work (but it does as SVGs...?)
Make them work
Right now, papertrail just dumps a bunch of logs into slack, which is suboptimal. Ideally, we could get rid of that integration, have rollbar capture all of those platform errors, and it can do what it does about creating more relevant github issues and whatnot. We don't want issues like #47 that address a concern but don't actually pinpoint a problem.
The rollbar people suggested we:
We'll probably go with option 2 unless rollbar ever makes a heroku/papertrail integration. Until then, we'll have to make our own solution.
OpenSearch is how we get ourselves into people's omnibar and able to search things. Not fully aware how this works. It looks like it's a document that puts you into a user's browser, but also can suggest things in there if we provide it the right way.
Doubt this link will keep working, but: https://www.google.com/analytics/web/#management/Settings/a64246820w111230619p116074022/%3Fm.page%3DPropertySettings%26m-content-embed.state%3Dembed.admin.integrations.wmx%26m-content-embed.dataset%3Da64246820w111230619p116074022%26m-content-embed.noForward%3Dfalse/
Make sure to give them the URL to the sitemap as well.
When different elements are clicked or interacted with, I wanna know!
When trying to add two logos that are on the bottom of the page to the collection, you have to scroll up between adding the two since the collection gets in the way. Having the margin always be on the bottom of the page fixes this. @cameronrohani has a different, mystery solution he's working on.
There's some logos that don't have both their height/width set, so when we convert it, svgtopng
get upset. We then set both ourselves, but we shouldn't have to (and we're doing twice the work). We should set the logos or have the repos that host them have them set.
The seanherron/Flag-Webicons repo seems to be the worst offender of this.
View details in Rollbar: https://rollbar.com/instantlogosearch/instantlogosearch/items/9/
Error: Width or height could not be determined from "/app/node_modules/instant-logos/node_modules/seanherron_Gov-Webicons/images/gov-usa.svg"
File "/app/node_modules/svg2png/lib/svg2png.js", line 52, in processResult
throw new Error(stdout.replace(/\r/g, "").trim());
File "node.js", line 357, in process._tickCallback
MainPage
and ShortnamePage
We occasionally crash. What's going on?
Also, don't let new txt files happen.
Things like this.
Once we have permalinks (or URLs of any kind) for searching, we need to setup Google Analytics to give us good data on it.
https://support.google.com/analytics/answer/1012264?hl=en
(Also, make sure we send a pageview whenever we search something)
Related to #18
Make OpenSearch have the capability of returning an xml "response" document. This gives OpenSearch actual results to display, which would be VERY cool.
First time will have a button/text/clickable that expands, THEN infinite scroll.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.